passing on PHPStan 2.1.18

Author: TomasVotruba

.github/workflows/phpstan_printer_test.yaml

@@ -0,0 +1,41 @@
+name: PHPStan Printer Test
+
+on:
+    pull_request: null
+    push:
+     branches:
+        - main
+
+
+
+env:
+    # see https://github.com/composer/composer/issues/9368#issuecomment-718112361
+    COMPOSER_ROOT_VERSION: "dev-main"
+
+jobs:
+    tests:
+        strategy:
+            fail-fast: false
+            matrix:
+                os: [ubuntu-latest, windows-latest]
+                php-versions: ['8.2']
+
+        runs-on: ${{ matrix.os }}
+        timeout-minutes: 3
+
+        name: PHP ${{ matrix.php-versions }} tests (${{ matrix.os }})
+        steps:
+            -   uses: actions/checkout@v4
+
+            -
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: ${{ matrix.php-versions }}
+                    coverage: none
+                    # to display warning when assert() is called, eg: on direct getArgs() on CallLike
+                    # and check against first class callable strlen(...)
+                    ini-values: zend.assertions=1
+
+            -   uses: "ramsey/composer-install@v3"
+
+            -   run: vendor/bin/phpunit tests/PhpParser/Printer/PHPStanPrinterTest.php --colors

composer.json

@@ -23,7 +23,7 @@
         "nikic/php-parser": "^5.6.2",
         "ondram/ci-detector": "^4.2",
         "phpstan/phpdoc-parser": "^2.3",
-        "phpstan/phpstan": "2.1.19 as 2.1.32",
+        "phpstan/phpstan": "2.1.18 as 2.1.32",
         "react/event-loop": "^1.6",
         "react/promise": "^3.3",
         "react/socket": "^1.17",

tests/PhpParser/Printer/Fixture/some_array_map.php

@@ -2,7 +2,4 @@
 
 namespace Rector\Tests\PhpParser\Printer\Fixture;
 
-$result = array_map(
-    array: [1, 2, 3],
-    callback: fn (int $value) => $value
-);
+$result = array_map(array: [1, 2, 3], callback: fn(int $value) => $value);

tests/PhpParser/Printer/PHPStanPrinterTest.php

@@ -29,7 +29,9 @@ public function testAddingCommentOnSomeNodesFail(): void
         $innerParser = $parserReflectionProperty->getValue($phpstanParser);
         $tokens = $innerParser->getTokens();
 
-        $standardPrinter = new Standard();
+        $standardPrinter = new Standard([
+            'newline' => "\n",
+        ]);
         $printerContents = $standardPrinter->printFormatPreserving($stmts, $stmts, $tokens);
 
         $this->assertStringEqualsFile(__DIR__ . '/Fixture/some_array_map.php', $printerContents);