cover class constants in StringClassNameToClassConstantRector, as no reason to skip them

Author: TomasVotruba

rules-tests/Php55/Rector/String_/StringClassNameToClassConstantRector/Fixture/include_class_const.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+namespace Rector\Tests\Php55\Rector\String_\StringClassNameToClassConstantRector\Fixture;
+
+final class IncludeClassConst
+{
+    const SKIP_TYPES = [
+        'Rector\Tests\Php55\Rector\String_\StringClassNameToClassConstantRector\Source\SomeUser'
+    ];
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php55\Rector\String_\StringClassNameToClassConstantRector\Fixture;
+
+final class IncludeClassConst
+{
+    const SKIP_TYPES = [
+        \Rector\Tests\Php55\Rector\String_\StringClassNameToClassConstantRector\Source\SomeUser::class
+    ];
+}
+
+?>

rules-tests/Php55/Rector/String_/StringClassNameToClassConstantRector/Fixture/skip_dynamic_variable.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\Php55\Rector\String_\StringClassNameToClassConstantRector\Fixture;
 
-class SkipDynamicVariable
+final class SkipDynamicVariable
 {
     public function bar()
     {
@@ -12,4 +12,13 @@ class SkipDynamicVariable
             ${'field'.$i} = $employee->data['dd'.$i];
         }
     }
-}
+
+    public function foo()
+    {
+        $dd1 = 1;
+
+        for ($i=1; $i <= 2; $i++) {
+            ${'field'.$i} = ${'dd'.$i};
+        }
+    }
+}

rules-tests/Php55/Rector/String_/StringClassNameToClassConstantRector/Fixture/skip_dynamic_variable2.php.inc

@@ -10,7 +10,6 @@
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Scalar\String_;
-use PhpParser\Node\Stmt\ClassConst;
 use PhpParser\NodeVisitor;
 use PHPStan\Reflection\ReflectionProvider;
 use Rector\Contract\Rector\ConfigurableRectorInterface;
@@ -89,20 +88,15 @@ public function run()
      */
     public function getNodeTypes(): array
     {
-        return [String_::class, FuncCall::class, ClassConst::class];
+        return [String_::class, FuncCall::class];
     }
 
     /**
-     * @param String_|FuncCall|ClassConst $node
+     * @param String_|FuncCall $node
      * @return Concat|ClassConstFetch|null|NodeVisitor::DONT_TRAVERSE_CHILDREN
      */
     public function refactor(Node $node): Concat|ClassConstFetch|null|int
     {
-        // allow class strings to be part of class const arrays, as probably on purpose
-        if ($node instanceof ClassConst) {
-            return NodeVisitor::DONT_TRAVERSE_CHILDREN;
-        }
-
         // keep allowed string as condition
         if ($node instanceof FuncCall) {
             if ($this->isName($node, 'is_a')) {