Skip to content

Commit 5558f62

Browse files
committed
make use of Override attribute
1 parent 8cbba43 commit 5558f62

22 files changed

Lines changed: 65 additions & 6 deletions

rector.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
use Rector\Config\RectorConfig;
77
use Rector\DeadCode\Rector\ConstFetch\RemovePhpVersionIdCheckRector;
88
use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
9-
use Rector\Php83\Rector\ClassConst\AddTypeToConstRector;
109
use Rector\PHPUnit\CodeQuality\Rector\Class_\AddSeeTestAnnotationRector;
1110
use Rector\Utils\Rector\RemoveRefactorDuplicatedNodeInstanceCheckRector;
1211

@@ -26,7 +25,7 @@
2625
)
2726
->withAttributesSets()
2827
->withComposerBased(phpunit: true)
29-
->withPhpSets(php82: true)
28+
->withPhpSets()
3029
->withPaths([
3130
__DIR__ . '/bin',
3231
__DIR__ . '/config',
@@ -40,10 +39,7 @@
4039
])
4140
->withRootFiles()
4241
->withImportNames(removeUnusedImports: true)
43-
->withRules([
44-
RemoveRefactorDuplicatedNodeInstanceCheckRector::class, AddSeeTestAnnotationRector::class,
45-
AddTypeToConstRector::class,
46-
])
42+
->withRules([RemoveRefactorDuplicatedNodeInstanceCheckRector::class, AddSeeTestAnnotationRector::class])
4743
->withSkip([
4844
StringClassNameToClassConstantRector::class,
4945
// tests

rules/Php81/Rector/Array_/FirstClassCallableRector.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace Rector\Php81\Rector\Array_;
66

7+
use Override;
78
use PhpParser\Node;
89
use PhpParser\Node\Expr\MethodCall;
910
use PhpParser\Node\Expr\StaticCall;
@@ -15,6 +16,7 @@
1516
*/
1617
final class FirstClassCallableRector extends ArrayToFirstClassCallableRector implements DeprecatedInterface
1718
{
19+
#[Override]
1820
public function refactor(Node $node): StaticCall|MethodCall|null
1921
{
2022
throw new ShouldNotHappenException(sprintf(

src/BetterPhpDocParser/PhpDoc/SpacelessPhpDocTagNode.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace Rector\BetterPhpDocParser\PhpDoc;
66

7+
use Override;
78
use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagNode;
89
use Stringable;
910

@@ -13,6 +14,7 @@
1314
*/
1415
final class SpacelessPhpDocTagNode extends PhpDocTagNode implements Stringable
1516
{
17+
#[Override]
1618
public function __toString(): string
1719
{
1820
return $this->name . $this->value;

src/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
namespace Rector\BetterPhpDocParser\PhpDocParser;
66

77
use Nette\Utils\Strings;
8+
use Override;
89
use PhpParser\Node;
910
use PHPStan\PhpDocParser\Ast\PhpDoc\GenericTagValueNode;
1011
use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocChildNode;
@@ -90,6 +91,7 @@ public function parseWithNode(BetterTokenIterator $betterTokenIterator, Node $no
9091
return $phpDocNode;
9192
}
9293

94+
#[Override]
9395
public function parseTag(TokenIterator $tokenIterator): PhpDocTagNode
9496
{
9597
// replace generic nodes with DoctrineAnnotations
@@ -106,6 +108,7 @@ public function parseTag(TokenIterator $tokenIterator): PhpDocTagNode
106108
/**
107109
* @param BetterTokenIterator $tokenIterator
108110
*/
111+
#[Override]
109112
public function parseTagValue(TokenIterator $tokenIterator, string $tag): PhpDocTagValueNode
110113
{
111114
$isPrecededByHorizontalWhitespace = $tokenIterator->isPrecededByHorizontalWhitespace();

src/BetterPhpDocParser/ValueObject/PhpDoc/SpacingAwareTemplateTagValueNode.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace Rector\BetterPhpDocParser\ValueObject\PhpDoc;
66

7+
use Override;
78
use PHPStan\PhpDocParser\Ast\PhpDoc\TemplateTagValueNode;
89
use PHPStan\PhpDocParser\Ast\Type\TypeNode;
910
use Stringable;
@@ -19,6 +20,7 @@ public function __construct(
1920
parent::__construct($name, $typeNode, $description);
2021
}
2122

23+
#[Override]
2224
public function __toString(): string
2325
{
2426
// @see https://github.com/rectorphp/rector/issues/3438

src/BetterPhpDocParser/ValueObject/Type/BracketsAwareIntersectionTypeNode.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,13 @@
44

55
namespace Rector\BetterPhpDocParser\ValueObject\Type;
66

7+
use Override;
78
use PHPStan\PhpDocParser\Ast\Type\IntersectionTypeNode;
89
use Stringable;
910

1011
final class BracketsAwareIntersectionTypeNode extends IntersectionTypeNode implements Stringable
1112
{
13+
#[Override]
1214
public function __toString(): string
1315
{
1416
return implode('&', $this->types);

src/BetterPhpDocParser/ValueObject/Type/BracketsAwareUnionTypeNode.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace Rector\BetterPhpDocParser\ValueObject\Type;
66

7+
use Override;
78
use PHPStan\PhpDocParser\Ast\Type\TypeNode;
89
use PHPStan\PhpDocParser\Ast\Type\UnionTypeNode;
910
use Stringable;
@@ -23,6 +24,7 @@ public function __construct(
2324
/**
2425
* Preserve common format
2526
*/
27+
#[Override]
2628
public function __toString(): string
2729
{
2830
$types = [];

src/BetterPhpDocParser/ValueObject/Type/FullyQualifiedIdentifierTypeNode.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,13 @@
44

55
namespace Rector\BetterPhpDocParser\ValueObject\Type;
66

7+
use Override;
78
use PHPStan\PhpDocParser\Ast\Type\IdentifierTypeNode;
89
use Stringable;
910

1011
final class FullyQualifiedIdentifierTypeNode extends IdentifierTypeNode implements Stringable
1112
{
13+
#[Override]
1214
public function __toString(): string
1315
{
1416
return '\\' . ltrim($this->name, '\\');

src/BetterPhpDocParser/ValueObject/Type/SpacingAwareArrayTypeNode.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace Rector\BetterPhpDocParser\ValueObject\Type;
66

7+
use Override;
78
use PHPStan\PhpDocParser\Ast\Type\ArrayTypeNode;
89
use PHPStan\PhpDocParser\Ast\Type\CallableTypeNode;
910
use PHPStan\PhpDocParser\Ast\Type\GenericTypeNode;
@@ -14,6 +15,7 @@
1415

1516
final class SpacingAwareArrayTypeNode extends ArrayTypeNode implements Stringable
1617
{
18+
#[Override]
1719
public function __toString(): string
1820
{
1921
if ($this->type instanceof CallableTypeNode) {

src/BetterPhpDocParser/ValueObject/Type/SpacingAwareCallableTypeNode.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,13 @@
44

55
namespace Rector\BetterPhpDocParser\ValueObject\Type;
66

7+
use Override;
78
use PHPStan\PhpDocParser\Ast\Type\CallableTypeNode;
89
use Stringable;
910

1011
final class SpacingAwareCallableTypeNode extends CallableTypeNode implements Stringable
1112
{
13+
#[Override]
1214
public function __toString(): string
1315
{
1416
// keep original (Psalm?) format, see https://github.com/rectorphp/rector/issues/2841

0 commit comments

Comments
 (0)