[CodeQuality] Handle with assign on SimplifyIfElseToTernaryRector

Author: samsonasik

rules-tests/CodeQuality/Rector/If_/SimplifyIfElseToTernaryRector/Fixture/with_assign.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\If_\SimplifyIfElseToTernaryRector\Fixture;
+
+class WithAssign
+{
+    public function run()
+    {
+        if ($a = $this->methodX()) {
+            $this->out = $a;
+        } else {
+            $this->out = $this->methodY();
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\If_\SimplifyIfElseToTernaryRector\Fixture;
+
+class WithAssign
+{
+    public function run()
+    {
+        $this->out = ($a = $this->methodX()) ? $a : $this->methodY();
+    }
+}
+
+?>

rules/CodeQuality/Rector/If_/SimplifyIfElseToTernaryRector.php

@@ -125,7 +125,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if ($ternary->cond instanceof BinaryOp) {
+        if ($ternary->cond instanceof BinaryOp || $ternary->cond instanceof Assign) {
             $ternary->cond->setAttribute(AttributeKey::ORIGINAL_NODE, null);
         }