fix

Author: samsonasik

rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_equal_numeric_string.php.inc

@@ -2,11 +2,14 @@
 
 namespace Rector\Tests\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector\Fixture;
 
-final class SkipIdenticalNumericString
+/**
+ * @see https://3v4l.org/9XRF6
+ */
+final class SkipIdenticalNumericStringCompareBool
 {
     public function equal()
     {
-        var_dump(true == '1'); // true
-        var_dump(true === '1'); // false
+        var_dump(true == '1');
+        var_dump('1' == true);
     }
 }

rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php

@@ -103,11 +103,15 @@ public function refactor(Node $node): ?Node
 
     private function shouldSkipCompareNumericString(Type $leftStaticType, Type $rightStaticType): bool
     {
-        if ($leftStaticType->isString()->yes() && $rightStaticType->isNumericString()->yes()) {
-            return true;
+        if ($leftStaticType instanceof BooleanType) {
+            return $rightStaticType->isNumericString()->yes();
         }
 
-        return $rightStaticType->isString()->yes() && $leftStaticType->isNumericString()->yes();
+        if ($rightStaticType instanceof BooleanType) {
+            return $leftStaticType->isNumericString()->yes();
+        }
+
+        return false;
     }
 
     private function processIdenticalOrNotIdentical(Equal|NotEqual $node): Identical|NotIdentical