allow empty in StrictArrayParamDimFetchRector to make rule more practical

Author: TomasVotruba

rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/empty_index.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class EmptyIndex
+{
+    public function run($param): void
+    {
+        if (! empty($param['index'])) {
+            $index = $param['index'];
+        } else {
+            $index = 100;
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class EmptyIndex
+{
+    public function run(array $param): void
+    {
+        if (! empty($param['index'])) {
+            $index = $param['index'];
+        } else {
+            $index = 100;
+        }
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_empty_index.php.inc

@@ -140,7 +140,7 @@ private function isParamAccessedArrayDimFetch(Param $param, ClassMethod|Function
                 return NodeVisitor::DONT_TRAVERSE_CURRENT_AND_CHILDREN;
             }
 
-            if ($this->shouldStop($node, $param, $paramName)) {
+            if ($this->shouldStop($node, $paramName)) {
                 // force set to false to avoid too early replaced
                 $isParamAccessedArrayDimFetch = false;
                 return NodeVisitor::STOP_TRAVERSAL;
@@ -209,16 +209,11 @@ private function isEchoed(Node $node, string $paramName): bool
         return false;
     }
 
-    private function shouldStop(Node $node, Param $param, string $paramName): bool
+    private function shouldStop(Node $node, string $paramName): bool
     {
         $nodeToCheck = null;
 
-        if (! $param->default instanceof Expr && ($node instanceof Empty_ && $node->expr instanceof ArrayDimFetch && $node->expr->var instanceof Variable && $node->expr->var->name === $paramName)) {
-            return true;
-        }
-
-        if ($node instanceof FuncCall
-            && ! $node->isFirstClassCallable()
+        if ($node instanceof FuncCall && ! $node->isFirstClassCallable()
             && $this->isNames($node, ['is_array', 'is_string', 'is_int', 'is_bool', 'is_float'])) {
             $firstArg = $node->getArgs()[0];
             $nodeToCheck = $firstArg->value;