Skip to content

Commit 6394422

Browse files
committed
fixes
1 parent ae4853f commit 6394422

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

rules/CodingStyle/Rector/Closure/StaticClosureRector.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
namespace Rector\CodingStyle\Rector\Closure;
66

7-
use Override;
87
use PhpParser\Node;
98
use PhpParser\Node\Expr\CallLike;
109
use PhpParser\Node\Expr\Closure;
@@ -68,7 +67,6 @@ public function getNodeTypes(): array
6867
return [Closure::class];
6968
}
7069

71-
#[Override]
7270
public function beforeTraverse(array $nodes): array
7371
{
7472
parent::beforeTraverse($nodes);

src/NodeAnalyzer/CallLikeExpectsThisBindedClosureArgsAnalyzer.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
use Rector\PHPStan\ScopeFetcher;
1313
use Rector\Reflection\ReflectionResolver;
1414

15-
class CallLikeExpectsThisBindedClosureArgsAnalyzer
15+
final class CallLikeExpectsThisBindedClosureArgsAnalyzer
1616
{
1717
public function __construct(
1818
private readonly ReflectionResolver $reflectionResolver
@@ -43,13 +43,13 @@ public function getArgsUsingThisBindedClosure(CallLike $callLike): array
4343
$parameters = $parametersAcceptor->getParameters();
4444

4545
foreach ($callLike->getArgs() as $index => $arg) {
46-
4746
if (! $arg->value instanceof Closure) {
4847
continue;
4948
}
5049

5150
if ($arg->name?->name !== null) {
5251
foreach ($parameters as $parameter) {
52+
/** @phpstan-ignore method.notFound */
5353
$hasObjectBinding = (bool) $parameter->getClosureThisType();
5454
if ($hasObjectBinding && $arg->name->name === $parameter->getName()) {
5555
$args[] = $arg;
@@ -66,7 +66,9 @@ public function getArgsUsingThisBindedClosure(CallLike $callLike): array
6666
continue;
6767
}
6868

69-
if ($parameter->getClosureThisType() !== null) {
69+
/** @phpstan-ignore method.notFound */
70+
$hasObjectBinding = (bool) $parameter->getClosureThisType();
71+
if ($hasObjectBinding) {
7072
$args[] = $arg;
7173
}
7274
}

0 commit comments

Comments
 (0)