use existing attribute

Author: TomasVotruba

rules/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector.php

@@ -8,7 +8,6 @@
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\ArrowFunction;
-use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\CallLike;
 use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Expr\FuncCall;
@@ -26,6 +25,7 @@
 use PHPStan\Reflection\Native\NativeFunctionReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\CallableType;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PhpParser\AstResolver;
 use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
@@ -45,11 +45,6 @@ final class FunctionLikeToFirstClassCallableRector extends AbstractRector implem
      */
     private const HAS_CALLBACK_SIGNATURE_MULTI_PARAMS = 'has_callback_signature_multi_params';
 
-    /**
-     * @var string
-     */
-    private const IS_IN_ASSIGN = 'is_in_assign';
-
     public function __construct(
         private readonly AstResolver $astResolver,
         private readonly ReflectionResolver $reflectionResolver
@@ -77,22 +72,14 @@ function ($parameter) {
 
     public function getNodeTypes(): array
     {
-        return [Assign::class, CallLike::class, ArrowFunction::class, Closure::class];
+        return [CallLike::class, ArrowFunction::class, Closure::class];
     }
 
     /**
      * @param CallLike|ArrowFunction|Closure $node
      */
     public function refactor(Node $node): null|CallLike
     {
-        if ($node instanceof Assign) {
-            if ($node->expr instanceof Closure || $node->expr instanceof ArrowFunction) {
-                $node->expr->setAttribute(self::IS_IN_ASSIGN, true);
-            }
-
-            return null;
-        }
-
         if ($node instanceof CallLike) {
             if ($node->isFirstClassCallable()) {
                 return null;
@@ -186,7 +173,9 @@ private function shouldSkip(
             return true;
         }
 
-        if ($node->getAttribute(self::IS_IN_ASSIGN) === true) {
+        if ($node->getAttribute(AttributeKey::IS_ASSIGNED_TO) === true || $node->getAttribute(
+            AttributeKey::IS_BEING_ASSIGNED
+        )) {
             return true;
         }