Deprecate StaticToSelfStaticMethodCallOnFinalClassRector and ConvertStaticPrivateConstantToSelfRector

Author: samsonasik

rules/CodeQuality/Rector/ClassConstFetch/ConvertStaticPrivateConstantToSelfRector.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
 use Rector\CodeQuality\Rector\Class_\ConvertStaticToSelfRector;
+use Rector\Exception\ShouldNotHappenException;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -16,11 +17,6 @@
  */
 final class ConvertStaticPrivateConstantToSelfRector extends AbstractRector
 {
-    public function __construct(
-        private readonly ConvertStaticToSelfRector $convertStaticToSelfRector
-    ) {
-    }
-
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
@@ -72,6 +68,10 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Class_
     {
-        return $this->convertStaticToSelfRector->refactor($node);
+        throw new ShouldNotHappenException(sprintf(
+            'The % rule is deprecated. Use %s instead',
+            self::class,
+            ConvertStaticToSelfRector::class,
+        ));
     }
 }

rules/CodeQuality/Rector/Class_/StaticToSelfStaticMethodCallOnFinalClassRector.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
+use Rector\Exception\ShouldNotHappenException;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -15,11 +16,6 @@
  */
 final class StaticToSelfStaticMethodCallOnFinalClassRector extends AbstractRector
 {
-    public function __construct(
-        private readonly ConvertStaticToSelfRector $convertStaticToSelfRector
-    ) {
-    }
-
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition('Change `static::methodCall()` to `self::methodCall()` on final class', [
@@ -70,6 +66,10 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Class_
     {
-        return $this->convertStaticToSelfRector->refactor($node);
+        throw new ShouldNotHappenException(sprintf(
+            'The % rule is deprecated. Use %s instead',
+            self::class,
+            ConvertStaticToSelfRector::class,
+        ));
     }
 }