const

Author: TomasVotruba

composer.json

@@ -20,7 +20,11 @@
         "doctrine/inflector": "^2.1",
         "illuminate/container": "^11.46",
         "nette/utils": "^4.0",
+<<<<<<< HEAD
         "nikic/php-parser": "^5.6.2",
+=======
+        "nikic/php-parser": "5.6.1",
+>>>>>>> 2a1a5105ab (lock php parser to 5.6.1 to avoid breaking space on attributes)
         "ondram/ci-detector": "^4.2",
         "phpstan/phpdoc-parser": "^2.3",
         "phpstan/phpstan": "^2.1.26",

rules/DeadCode/Rector/ClassMethod/RemoveUnusedPublicMethodParameterRector.php

@@ -13,6 +13,8 @@
 use Rector\NodeAnalyzer\MagicClassMethodAnalyzer;
 use Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer;
 use Rector\Rector\AbstractRector;
+use Rector\Symfony\Enum\SymfonyClass;
+use Rector\ValueObject\MethodName;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -115,7 +117,7 @@ private function shouldSkipClassMethod(ClassMethod $classMethod, Class_ $class):
         }
 
         // parameter is required for contract coupling
-        if ($this->isName($classMethod->name, '__invoke') && $this->phpAttributeAnalyzer->hasPhpAttribute(
+        if ($this->isName($classMethod->name, MethodName::INVOKE) && $this->phpAttributeAnalyzer->hasPhpAttribute(
             $class,
             'Symfony\Component\Messenger\Attribute\AsMessageHandler'
         )) {

utils/Rector/RemoveRefactorDuplicatedNodeInstanceCheckRector.php

@@ -0,0 +1,80 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Utils\Rector;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\PropertyFetch;
+use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\If_;
+use PhpParser\Node\Stmt\Property;
+use PHPStan\Type\ObjectType;
+use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
+use Rector\NodeManipulator\ClassDependencyManipulator;
+use Rector\PhpParser\Node\BetterNodeFinder;
+use Rector\PhpParser\Node\Value\ValueResolver;
+use Rector\PostRector\ValueObject\PropertyMetadata;
+use Rector\Rector\AbstractRector;
+use Rector\StaticTypeMapper\StaticTypeMapper;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+final class RemoveRefactorDuplicatedNodeInstanceCheckRector extends AbstractRector
+{
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition('Remove refactor() method of Rector rule double check of $node instance, if already defined in @param type', []);
+    }
+
+    public function getNodeTypes(): array
+    {
+        return [Node\Stmt\ClassMethod::class];
+    }
+
+    /**
+     * @param Node\Stmt\ClassMethod $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if (! $this->isName($node->name, 'refactor')) {
+            return null;
+        }
+
+        if (! $node->isPublic()) {
+            return null;
+        }
+
+        $firstStmt = $node->stmts[0] ?? null;
+        if (! $firstStmt instanceof If_) {
+            return null;
+        }
+
+        // remove already added properties
+
+        if ($typesToAdd === []) {
+            return null;
+        }
+
+        $hasChanged = false;
+
+        foreach ($typesToAdd as $propertyNameToAdd => $propertyTypeToAdd) {
+            // skip if property already exists
+            if ($node->getProperty($propertyNameToAdd) instanceof Property) {
+                continue;
+            }
+
+            $this->classDependencyManipulator->addConstructorDependency(
+                $node,
+                new PropertyMetadata($propertyNameToAdd, new ObjectType($propertyTypeToAdd))
+            );
+
+            $hasChanged = true;
+        }
+
+        if (! $hasChanged) {
+            return null;
+        }
+
+        return $node;
+    }
+}