add test

Author: TomasVotruba

composer.json

@@ -20,11 +20,7 @@
         "doctrine/inflector": "^2.1",
         "illuminate/container": "^11.46",
         "nette/utils": "^4.0",
-<<<<<<< HEAD
         "nikic/php-parser": "^5.6.2",
-=======
-        "nikic/php-parser": "5.6.1",
->>>>>>> 2a1a5105ab (lock php parser to 5.6.1 to avoid breaking space on attributes)
         "ondram/ci-detector": "^4.2",
         "phpstan/phpdoc-parser": "^2.3",
         "phpstan/phpstan": "^2.1.26",
@@ -85,6 +81,7 @@
                 "rules-tests",
                 "tests"
             ],
+            "Rector\\Utils\\Tests\\": "utils-tests",
             "E2e\\Parallel\\Reflection\\Resolver\\": [
                 "e2e/parallel-reflection-resolver/src/",
                 "e2e/no-parallel-reflection-resolver/src"

phpstan.neon

@@ -352,3 +352,5 @@ parameters:
         -
             identifier: offsetAccess.invalidOffset
             path: src/CustomRules/SimpleNodeDumper.php
+
+        - '#Method Rector\\Utils\\Rector\\RemoveRefactorDuplicatedNodeInstanceCheckRector\:\:getInstanceofNodeClass\(\) should return class\-string<PhpParser\\Node>\|null but returns class\-string#'

phpunit.xml

@@ -13,6 +13,7 @@
         <testsuite name="main">
             <directory>tests</directory>
             <directory>rules-tests</directory>
+            <directory>utils-tests</directory>
         </testsuite>
     </testsuites>
 

rules/CodeQuality/Rector/BooleanNot/ReplaceConstantBooleanNotRector.php

@@ -69,10 +69,6 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if (! $node instanceof BooleanNot) {
-            return null;
-        }
-
         if ($this->valueResolver->isFalse($node->expr)) {
             return new ConstFetch(new Name('true'));
         }

rules/CodingStyle/Rector/FuncCall/FunctionFirstClassCallableRector.php

@@ -61,12 +61,11 @@ public function getNodeTypes(): array
         return [FuncCall::class];
     }
 
+    /**
+     * @param FuncCall $node
+     */
     public function refactor(Node $node): ?FuncCall
     {
-        if (! $node instanceof FuncCall) {
-            return null;
-        }
-
         if (! $node->name instanceof Name) {
             return null;
         }

utils-tests/Rector/RemoveRefactorDuplicatedNodeInstanceCheckRector/Fixture/cover_bare_get_node_types.php.inc

@@ -0,0 +1,54 @@
+<?php
+
+namespace Rector\Utils\Tests\Rector\RemoveRefactorDuplicatedNodeInstanceCheckRector\Fixture;
+
+use PhpParser\Node;
+use Rector\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+final class CoverBareGetNodeTypes extends AbstractRector
+{
+    public function getRuleDefinition(): RuleDefinition
+    {
+    }
+
+    public function getNodeTypes(): array
+    {
+        return [Node\Stmt\ClassMethod::class];
+    }
+
+    public function refactor(Node $node)
+    {
+        if (! $node instanceof Node\Stmt\ClassMethod) {
+            return null;
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Utils\Tests\Rector\RemoveRefactorDuplicatedNodeInstanceCheckRector\Fixture;
+
+use PhpParser\Node;
+use Rector\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+final class CoverBareGetNodeTypes extends AbstractRector
+{
+    public function getRuleDefinition(): RuleDefinition
+    {
+    }
+
+    public function getNodeTypes(): array
+    {
+        return [Node\Stmt\ClassMethod::class];
+    }
+
+    public function refactor(Node $node)
+    {
+    }
+}
+
+?>

utils-tests/Rector/RemoveRefactorDuplicatedNodeInstanceCheckRector/Fixture/some_class.php.inc

@@ -0,0 +1,60 @@
+<?php
+
+namespace Rector\Utils\Tests\Rector\RemoveRefactorDuplicatedNodeInstanceCheckRector\Fixture;
+
+use PhpParser\Node;
+use Rector\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+final class SomeClass extends AbstractRector
+{
+    public function getRuleDefinition(): RuleDefinition
+    {
+    }
+
+    public function getNodeTypes(): array
+    {
+        return [Node\Stmt\ClassMethod::class];
+    }
+
+    /**
+     * @param Node\Stmt\ClassMethod $node
+     */
+    public function refactor(Node $node)
+    {
+        if (! $node instanceof Node\Stmt\ClassMethod) {
+            return null;
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Utils\Tests\Rector\RemoveRefactorDuplicatedNodeInstanceCheckRector\Fixture;
+
+use PhpParser\Node;
+use Rector\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+final class SomeClass extends AbstractRector
+{
+    public function getRuleDefinition(): RuleDefinition
+    {
+    }
+
+    public function getNodeTypes(): array
+    {
+        return [Node\Stmt\ClassMethod::class];
+    }
+
+    /**
+     * @param Node\Stmt\ClassMethod $node
+     */
+    public function refactor(Node $node)
+    {
+    }
+}
+
+?>

utils-tests/Rector/RemoveRefactorDuplicatedNodeInstanceCheckRector/RemoveRefactorDuplicatedNodeInstanceCheckRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Utils\Tests\Rector\RemoveRefactorDuplicatedNodeInstanceCheckRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class RemoveRefactorDuplicatedNodeInstanceCheckRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

utils-tests/Rector/RemoveRefactorDuplicatedNodeInstanceCheckRector/config/configured_rule.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Utils\Rector\RemoveRefactorDuplicatedNodeInstanceCheckRector;
+
+return RectorConfig::configure()
+    ->withRules([
+        RemoveRefactorDuplicatedNodeInstanceCheckRector::class,
+    ]);