skip connection calls in AddReturnDocblockFromMethodCallDocblockRector

Author: TomasVotruba

rules-tests/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockFromMethodCallDocblockRector/Fixture/skip_fetch_first_column.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockFromMethodCallDocblockRector\Fixture;
+
+use Doctrine\DBAL\Connection;
+
+final class SkipFetchFirstColumn
+{
+    private Connection $connection;
+
+    public function __construct(Connection $connection)
+    {
+        $this->connection = $connection;
+    }
+
+    public function getAll(): array
+    {
+        return $this->connection->fetchFirstColumn();
+    }
+}

rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockFromMethodCallDocblockRector.php

@@ -10,8 +10,10 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Return_;
 use PHPStan\PhpDocParser\Ast\PhpDoc\ReturnTagValueNode;
+use PHPStan\Type\ObjectType;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger;
+use Rector\Doctrine\Enum\DoctrineClass;
 use Rector\PhpParser\AstResolver;
 use Rector\Rector\AbstractRector;
 use Rector\TypeDeclarationDocblocks\NodeFinder\ReturnNodeFinder;
@@ -120,6 +122,12 @@ public function refactor(Node $node): ?Node
 
         $returnedMethodCall = $onlyReturnWithExpr->expr;
 
+        // skip doctrine connection calls, as to generic and not helpful
+        $callerType = $this->getType($returnedMethodCall->var);
+        if ($callerType instanceof ObjectType && $callerType->isInstanceOf(DoctrineClass::CONNECTION)->yes()) {
+            return null;
+        }
+
         $calledClassMethod = $this->astResolver->resolveClassMethodFromCall($returnedMethodCall);
         if (! $calledClassMethod instanceof ClassMethod) {
             return null;
@@ -140,6 +148,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if (! $this->usefulArrayTagNodeAnalyzer->isUsefulArrayTag($calledReturnTagValue)) {
+            return null;
+        }
+
         $this->phpDocTypeChanger->changeReturnTypeNode($node, $phpDocInfo, $calledReturnTagValue->type);
 
         return $node;

stubs/Doctrine/DBAL/Connection.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\DBAL;
+
+final class Connection
+{
+    /**
+     * @return list<mixed>
+     */
+    public function fetchFirstColumn(string $query, array $params = [], array $types = []): array
+    {
+        return [];
+    }
+}