skip parent magic called method in PrivatizeFinalClassMethodRector

Author: TomasVotruba

rules/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector.php

@@ -86,6 +86,7 @@ public function getNodeTypes(): array
     public function refactor(Node $node): null|CallLike
     {
         if ($node instanceof Assign) {
+            // @todo handle by existing attribute already
             if ($node->expr instanceof Closure || $node->expr instanceof ArrowFunction) {
                 $node->expr->setAttribute(self::IS_IN_ASSIGN, true);
             }

rules/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector.php

@@ -30,6 +30,7 @@ public function __construct(
         private readonly OverrideByParentClassGuard $overrideByParentClassGuard,
         private readonly BetterNodeFinder $betterNodeFinder,
         private readonly LaravelModelGuard $laravelModelGuard,
+        private readonly \Rector\Privatization\VisibilityGuard\ParentClassMagicCallGuard $parentClassMagicCallGuard
     ) {
     }
 
@@ -107,6 +108,10 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if ($this->parentClassMagicCallGuard->containsParentClassMagicCall($node)) {
+                continue;
+            }
+
             if ($this->classMethodVisibilityGuard->isClassMethodVisibilityGuardedByTrait(
                 $classMethod,
                 $classReflection

rules/Privatization/VisibilityGuard/ParentClassMagicCallGuard.php

@@ -0,0 +1,72 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Privatization\VisibilityGuard;
+
+use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Stmt\Class_;
+use Rector\NodeNameResolver\NodeNameResolver;
+use Rector\PhpParser\AstResolver;
+use Rector\PhpParser\Node\BetterNodeFinder;
+
+final class ParentClassMagicCallGuard
+{
+    /**
+     * @var array<string, bool>
+     */
+    private array $cachedContainsByClassName = [];
+
+    public function __construct(
+        private readonly NodeNameResolver $nodeNameResolver,
+        private readonly AstResolver $astResolver,
+        private readonly BetterNodeFinder $betterNodeFinder
+    ) {
+    }
+
+    /**
+     * E.g. parent class has $this->{$magicName} call that might call the protected method
+     * If we make it private, it will break the code
+     */
+    public function containsParentClassMagicCall(Class_ $class): bool
+    {
+        // cache as heavy AST parsing here
+        $className = $this->nodeNameResolver->getName($class);
+        if (isset($this->cachedContainsByClassName[$className])) {
+            return $this->cachedContainsByClassName[$className];
+        }
+
+        if ($class->extends === null) {
+            return false;
+        }
+
+        $parentClassName = $this->nodeNameResolver->getName($class->extends);
+
+        $parentClass = $this->astResolver->resolveClassFromName($parentClassName);
+        if (! $parentClass instanceof Class_) {
+            $this->cachedContainsByClassName[$className] = false;
+            return false;
+        }
+
+        foreach ($parentClass->getMethods() as $classMethod) {
+            if ($classMethod->isAbstract()) {
+                continue;
+            }
+
+            /** @var MethodCall[] $methodCalls */
+            $methodCalls = $this->betterNodeFinder->findInstancesOfScoped(
+                (array) $classMethod->stmts,
+                MethodCall::class
+            );
+            foreach ($methodCalls as $methodCall) {
+                if ($methodCall->name instanceof Expr) {
+                    $this->cachedContainsByClassName[$className] = true;
+                    return true;
+                }
+            }
+        }
+
+        return $this->containsParentClassMagicCall($parentClass);
+    }
+}

src/ValueObject/Application/File.php

@@ -4,10 +4,10 @@
 
 namespace Rector\ValueObject\Application;
 
-use PhpParser\Node\Stmt\Namespace_;
 use PhpParser\Node;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\InlineHTML;
+use PhpParser\Node\Stmt\Namespace_;
 use PhpParser\NodeFinder;
 use PhpParser\Token;
 use Rector\ChangesReporting\ValueObject\RectorWithLineChange;