[NodeTypeResolver] Handle ArrayType with intersection string on AccessoryNonEmptyArrayTypeCorrector (#7332)

* [NodeTypeResolver] Handle ArrayType with intersection string on AccessoryNonEmptyArrayTypeCorrector

* [NodeTypeResolver] Handle ArrayType with intersection string on AccessoryNonEmptyArrayTypeCorrector

Author: samsonasik

src/NodeTypeResolver/NodeTypeCorrector/AccessoryNonEmptyArrayTypeCorrector.php

@@ -8,6 +8,7 @@
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\MixedType;
+use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
 
 final class AccessoryNonEmptyArrayTypeCorrector
@@ -26,6 +27,12 @@ public function correct(Type $mainType): Type
             if ($type instanceof NonEmptyArrayType) {
                 return new ArrayType(new MixedType(), new MixedType());
             }
+
+            if ($type instanceof ArrayType
+                && $type->getIterableValueType() instanceof IntersectionType
+                && $type->getIterableValueType()->isString()->yes()) {
+                return new ArrayType(new MixedType(), new StringType());
+            }
         }
 
         return $mainType;

src/NodeTypeResolver/NodeTypeResolver.php

@@ -34,13 +34,11 @@
 use PHPStan\Type\Constant\ConstantBooleanType;
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\ErrorType;
-use PHPStan\Type\IntegerType;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\NeverType;
 use PHPStan\Type\NullType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\ObjectWithoutClassType;
-use PHPStan\Type\StringType;
 use PHPStan\Type\ThisType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
@@ -180,11 +178,6 @@ public function getType(Node $node): Type
             }
         }
 
-        // correction for explode() that always returns array
-        if ($node instanceof FuncCall && $node->name instanceof Name && $node->name->toString() === 'explode') {
-            return new ArrayType(new IntegerType(), new StringType());
-        }
-
         if ($node instanceof Ternary) {
             $ternaryType = $this->resolveTernaryType($node);
             if (! $ternaryType instanceof MixedType) {