add back return by array shape test

Author: samsonasik

rules-tests/TypeDeclaration/Rector/ArrowFunction/AddArrowFunctionReturnTypeRector/Fixture/return_by_array_shape_type.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ArrowFunction\AddArrowFunctionReturnTypeRector\Fixture;
+
+class ReturnByArrayShapeType
+{
+    /**
+     * @param array<int, array{bar: int}> $values
+     */
+    private function foo(array $values): void
+    {
+        $bars = array_map(fn($value) => $value['bar'], $values);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ArrowFunction\AddArrowFunctionReturnTypeRector\Fixture;
+
+class ReturnByArrayShapeType
+{
+    /**
+     * @param array<int, array{bar: int}> $values
+     */
+    private function foo(array $values): void
+    {
+        $bars = array_map(fn($value): int => $value['bar'], $values);
+    }
+}
+
+?>

rules/TypeDeclaration/Rector/FuncCall/AddArrowFunctionParamArrayWhereDimFetchRector.php

@@ -12,7 +12,6 @@
 use PhpParser\Node\Expr\Instanceof_;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Identifier;
-use PhpParser\Node\Scalar\String_;
 use PHPStan\Type\ArrayType;
 use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\Rector\AbstractRector;
@@ -149,8 +148,7 @@ private function resolveDimFetchVariableNames(Closure|ArrowFunction $closureExpr
             if ($arrayDimFetch->var instanceof Variable) {
                 $type = $this->nodeTypeResolver->getNativeType($arrayDimFetch->var);
 
-                // skip string values
-                if (! $arrayDimFetch->dim instanceof String_ && ($type->isString()->yes() || $type->isString()->maybe())) {
+                if ($type->isString()->yes()) {
                     continue;
                 }