[dx] help - omit explicit command name as no longer needed; remove verbosity option, use debug instead (#7620)

* help, omit explicit command name as no longer needed

* remove version option, as not used; --debug is the way

Author: TomasVotruba

.github/workflows/compat_test.yaml

@@ -8,7 +8,7 @@ on:
     pull_request: null
 
 jobs:
-    compate_test:
+    compat_test:
         runs-on: ubuntu-latest
 
         steps:

src/Console/Command/ProcessCommand.php

@@ -57,19 +57,19 @@ protected function configure(): void
             <<<'EOF'
 The <info>%command.name%</info> command will run Rector main feature:
 
-  <info>%command.full_name%</info>
+  <info>vendor/bin/rector</info>
 
 To specify a folder or a file, you can run:
 
-  <info>%command.full_name% src/Controller</info>
+  <info>vendor/bin/rector src/Controller</info>
 
 You can also dry run to see the changes that Rector will make with the <comment>--dry-run</comment> option:
 
-  <info>%command.full_name% src/Controller --dry-run</info>
+  <info>vendor/bin/rector src/Controller --dry-run</info>
 
 It's also possible to get debug via the <comment>--debug</comment> option:
 
-  <info>%command.full_name% src/Controller --dry-run --debug</info>
+  <info>vendor/bin/rector src/Controller --dry-run --debug</info>
 EOF
         );
 

src/Console/ConsoleApplication.php

@@ -42,13 +42,7 @@ public function __construct(array $commands)
 
     public function doRun(InputInterface $input, OutputInterface $output): int
     {
-        $isXdebugAllowed = $input->hasParameterOption('--xdebug');
-        if (! $isXdebugAllowed) {
-            $xdebugHandler = new XdebugHandler('rector');
-            $xdebugHandler->setPersistent();
-            $xdebugHandler->check();
-            unset($xdebugHandler);
-        }
+        $this->enableXdebug($input);
 
         $shouldFollowByNewline = false;
 
@@ -68,14 +62,12 @@ public function doRun(InputInterface $input, OutputInterface $output): int
         // bin/rector src
         // bin/rector --only "RemovePhpVersionIdCheckRector"
         // file_exists() can check directory and file
-        if (is_string($commandName)
-            && (
-                file_exists($commandName)
-                || isset($_SERVER['argv'][1])
-                    && $commandName !== $_SERVER['argv'][1]
-                    // ensure verify has parameter option, eg: --only
-                    && $input->hasParameterOption($_SERVER['argv'][1])
-            )
+        if (is_string($commandName) && (
+            file_exists($commandName) || isset($_SERVER['argv'][1])
+            && $commandName !== $_SERVER['argv'][1]
+            // ensure verify has parameter option, eg: --only
+            && $input->hasParameterOption($_SERVER['argv'][1])
+        )
         ) {
             // prepend command name if implicit
             $privatesAccessor = new PrivatesAccessor();
@@ -117,7 +109,7 @@ private function removeUnusedOptions(InputDefinition $inputDefinition): void
     {
         $options = $inputDefinition->getOptions();
 
-        unset($options['quiet'], $options['no-interaction']);
+        unset($options['quiet'], $options['verbose'], $options['no-interaction']);
 
         $inputDefinition->setOptions($options);
     }
@@ -136,7 +128,7 @@ private function addCustomOptions(InputDefinition $inputDefinition): void
             Option::DEBUG,
             null,
             InputOption::VALUE_NONE,
-            'Enable debug verbosity (-vvv)'
+            'Enable debug verbosity'
         ));
 
         $inputDefinition->addOption(new InputOption(
@@ -158,4 +150,15 @@ private function getDefaultConfigPath(): string
     {
         return getcwd() . '/rector.php';
     }
+
+    private function enableXdebug(InputInterface $input): void
+    {
+        $isXdebugAllowed = $input->hasParameterOption('--xdebug');
+        if (! $isXdebugAllowed) {
+            $xdebugHandler = new XdebugHandler('rector');
+            $xdebugHandler->setPersistent();
+            $xdebugHandler->check();
+            unset($xdebugHandler);
+        }
+    }
 }

src/DependencyInjection/RectorContainerFactory.php

@@ -4,9 +4,9 @@
 
 namespace Rector\DependencyInjection;
 
-use Rector\Config\RectorConfig;
 use Rector\Autoloading\BootstrapFilesIncluder;
 use Rector\Caching\Detector\ChangedFilesDetector;
+use Rector\Config\RectorConfig;
 use Rector\ValueObject\Bootstrap\BootstrapConfigs;
 
 final class RectorContainerFactory