add support for boolean vs constant boolean type in UseIdenticalOverEqualWithSameTypeRector (#7408)

* add support for boolean vs constant boolean type

* fixup!  add support for boolean vs constant boolean type

Author: TomasVotruba

rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/identical_bool.php.inc

@@ -0,0 +1,45 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector\Fixture;
+
+final class IdenticalBool
+{
+    public function equal()
+    {
+        if ($this->getValue() == true) {
+            return 'yes';
+        }
+
+        return 'no';
+    }
+
+    private function getValue(): bool
+    {
+        return true;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector\Fixture;
+
+final class IdenticalBool
+{
+    public function equal()
+    {
+        if ($this->getValue() === true) {
+            return 'yes';
+        }
+
+        return 'no';
+    }
+
+    private function getValue(): bool
+    {
+        return true;
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/identical_string.php.inc

@@ -0,0 +1,45 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector\Fixture;
+
+final class IdenticalString
+{
+    public function equal()
+    {
+        if ($this->getValue() == 'hi') {
+            return 'yes';
+        }
+
+        return 'no';
+    }
+
+    private function getValue(): string
+    {
+        return 'hello';
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector\Fixture;
+
+final class IdenticalString
+{
+    public function equal()
+    {
+        if ($this->getValue() === 'hi') {
+            return 'yes';
+        }
+
+        return 'no';
+    }
+
+    private function getValue(): string
+    {
+        return 'hello';
+    }
+}
+
+?>

rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php

@@ -10,6 +10,7 @@
 use PhpParser\Node\Expr\BinaryOp\Identical;
 use PhpParser\Node\Expr\BinaryOp\NotEqual;
 use PhpParser\Node\Expr\BinaryOp\NotIdentical;
+use PHPStan\Type\BooleanType;
 use PHPStan\Type\MixedType;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -86,7 +87,9 @@ public function refactor(Node $node): ?Node
         }
 
         // different types
-        if (! $leftStaticType->equals($rightStaticType)) {
+        if (! $leftStaticType->equals(
+            $rightStaticType
+        ) && (! $leftStaticType instanceof BooleanType && ! $rightStaticType instanceof BooleanType)) {
             return null;
         }