allow coalesce not on full variable, but dim fetch in StrictArrayParamDimFetchRector (#7404)

Author: TomasVotruba

rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/direct-coalesce.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class DirectCoalesce
+{
+    public function run($productOptions)
+    {
+        return $productOptions['list'] ?? 'default';
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class DirectCoalesce
+{
+    public function run(array $productOptions)
+    {
+        return $productOptions['list'] ?? 'default';
+    }
+}
+
+?>

…etchRector/Fixture/skip_coalesce.php.inc …/skip_coalesce_without_dim_fetch.php.incrules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_coalesce.php.inc renamed to rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_coalesce_without_dim_fetch.php.inc rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_coalesce.php.inc renamed to rules-tests/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_coalesce_without_dim_fetch.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
 
-final class SkipCoalesce
+final class SkipCoalesceWithoutDimFetch
 {
     public function run($productOptions)
     {

rules/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector.php

@@ -236,7 +236,7 @@ private function shouldStop(Node $node, Param $param, string $paramName): bool
             $nodeToCheck = $node->var;
         }
 
-        if ($this->isMethodCallOrArrayDimFetch($paramName, $nodeToCheck)) {
+        if ($this->isMethodCall($paramName, $nodeToCheck)) {
             return true;
         }
 
@@ -295,16 +295,12 @@ private function isEmptyOrEchoedOrCasted(Node $node, string $paramName): bool
         return $node instanceof Array_ && $node->expr instanceof Variable && $this->isName($node->expr, $paramName);
     }
 
-    private function isMethodCallOrArrayDimFetch(string $paramName, ?Node $node): bool
+    private function isMethodCall(string $paramName, ?Node $node): bool
     {
         if ($node instanceof MethodCall) {
             return $node->var instanceof Variable && $this->isName($node->var, $paramName);
         }
 
-        if ($node instanceof ArrayDimFetch) {
-            return $node->var instanceof Variable && $this->isName($node->var, $paramName);
-        }
-
         return false;
     }