Skip parent methods in AddParamArrayDocblockFromDimFetchAccessRector (#7496)

* get param name directly, to avoid string type doc

* Skip parent methods in AddParamArrayDocblockFromDimFetchAccessRector

Author: TomasVotruba

rules-tests/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockFromDimFetchAccessRector/Fixture/skip_contract_enforced.php.inc

@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromDimFetchAccessRector\Fixture;
+
+use Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromDimFetchAccessRector\Source\EnforcingSomeContractInterface;
+
+final class SkipContractEnforced implements EnforcingSomeContractInterface
+{
+    public function process(array $data): void
+    {
+    }
+}

rules-tests/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockFromDimFetchAccessRector/Source/EnforcingSomeContractInterface.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromDimFetchAccessRector\Source;
+
+interface EnforcingSomeContractInterface
+{
+    /**
+     * @param mixed $data
+     */
+    public function process(array $data): void;
+}

rules/CodeQuality/Rector/Class_/DynamicDocBlockPropertyToNativePropertyRector.php

@@ -221,7 +221,7 @@ private function isPromotedProperty(Class_ $class, string $propertyName): bool
                     continue;
                 }
 
-                $paramName = $this->getName($param->var);
+                $paramName = $this->getName($param);
                 if ($paramName === $propertyName) {
                     return true;
                 }

rules/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector.php

@@ -141,12 +141,7 @@ private function resolveParamByRefVariables(ClassMethod|Function_|Closure $node)
                 continue;
             }
 
-            $paramName = $this->getName($param->var);
-            if ($paramName === null) {
-                continue;
-            }
-
-            $paramByRefVariables[] = $paramName;
+            $paramByRefVariables[] = $this->getName($param);
         }
 
         return $paramByRefVariables;

rules/DeadCode/Rector/ClassMethod/RemoveUselessAssignFromPropertyPromotionRector.php

@@ -82,7 +82,7 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
-            $variableNames[] = (string) $this->getName($param->var);
+            $variableNames[] = $this->getName($param);
         }
 
         if ($variableNames === []) {

rules/Naming/Naming/ExpectedNameResolver.php

@@ -45,9 +45,7 @@ public function resolveForParamIfNotYet(Param $param): ?string
             return null;
         }
 
-        /** @var string $currentName */
-        $currentName = $this->nodeNameResolver->getName($param->var);
-
+        $currentName = $this->nodeNameResolver->getName($param);
         if ($currentName === $expectedName || str_ends_with($currentName, ucfirst($expectedName))) {
             return null;
         }

rules/Naming/ValueObjectFactory/ParamRenameFactory.php

@@ -26,11 +26,7 @@ public function createFromResolvedExpectedName(
             return null;
         }
 
-        $currentName = $this->nodeNameResolver->getName($param->var);
-        if ($currentName === null) {
-            return null;
-        }
-
+        $currentName = $this->nodeNameResolver->getName($param);
         return new ParamRename($currentName, $expectedName, $param->var, $functionLike);
     }
 }

rules/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php

@@ -226,9 +226,8 @@ public function refactor(Node $node): ?Node
             $assignStmtPosition = $promotionCandidate->getStmtPosition();
             unset($constructClassMethod->stmts[$assignStmtPosition]);
 
-            /** @var string $oldName */
-            $oldName = $this->getName($param->var);
-            $this->variableRenamer->renameVariableInFunctionLike($constructClassMethod, $oldName, $propertyName, null);
+            $oldParamName = $this->getName($param);
+            $this->variableRenamer->renameVariableInFunctionLike($constructClassMethod, $oldParamName, $propertyName);
 
             $paramTagValueNode = $constructorPhpDocInfo->getParamTagValueByName($paramName);
 

rules/Renaming/Rector/FunctionLike/RenameFunctionLikeParamWithinCallLikeArgRector.php

@@ -126,7 +126,7 @@ public function refactor(Node $node): ?Node
                 ($functionLike instanceof Closure || $functionLike instanceof ArrowFunction) &&
                 (
                     $this->breakingVariableRenameGuard->shouldSkipVariable(
-                        (string) $this->getName($param->var),
+                        $this->getName($param),
                         $renameFunctionLikeParamWithinCallLikeArg->getNewParamName(),
                         $functionLike,
                         $param->var

rules/TypeDeclaration/Guard/ParamTypeAddGuard.php

@@ -27,10 +27,7 @@ public function __construct(
 
     public function isLegal(Param $param, ClassMethod $classMethod): bool
     {
-        $paramName = $this->nodeNameResolver->getName($param->var);
-        if ($paramName === null) {
-            return false;
-        }
+        $paramName = $this->nodeNameResolver->getName($param);
 
         $isLegal = true;