move SetterAndGetterFinder from doctrine to core, as useful in many extensions

Author: TomasVotruba

rector.php

@@ -8,6 +8,7 @@
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
 
 return RectorConfig::configure()
+    ->withTreatClassesAsFinal()
     ->withPreparedSets(
         deadCode: true,
         codeQuality: true,

rules/Php84/NodeFinder/SetterAndGetterFinder.php

@@ -0,0 +1,63 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php84\NodeFinder;
+
+use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\ClassMethod;
+use Rector\TypeDeclaration\NodeAnalyzer\ClassMethodAndPropertyAnalyzer;
+
+final readonly class SetterAndGetterFinder
+{
+    public function __construct(
+        private ClassMethodAndPropertyAnalyzer $classMethodAndPropertyAnalyzer
+    ) {
+    }
+
+    /**
+     * @return ClassMethod[]
+     */
+    public function findGetterAndSetterClassMethods(Class_ $class, string $propertyName): array
+    {
+        $classMethods = [];
+
+        $getterClassMethod = $this->findGetterClassMethod($class, $propertyName);
+        if ($getterClassMethod instanceof ClassMethod) {
+            $classMethods[] = $getterClassMethod;
+        }
+
+        $setterClassMethod = $this->findSetterClassMethod($class, $propertyName);
+        if ($setterClassMethod instanceof ClassMethod) {
+            $classMethods[] = $setterClassMethod;
+        }
+
+        return $classMethods;
+    }
+
+    public function findGetterClassMethod(Class_ $class, string $propertyName): ?ClassMethod
+    {
+        foreach ($class->getMethods() as $classMethod) {
+            if (! $this->classMethodAndPropertyAnalyzer->hasPropertyFetchReturn($classMethod, $propertyName)) {
+                continue;
+            }
+
+            return $classMethod;
+        }
+
+        return null;
+    }
+
+    public function findSetterClassMethod(Class_ $class, string $propertyName): ?ClassMethod
+    {
+        foreach ($class->getMethods() as $classMethod) {
+            if (! $this->classMethodAndPropertyAnalyzer->hasOnlyPropertyAssign($classMethod, $propertyName)) {
+                continue;
+            }
+
+            return $classMethod;
+        }
+
+        return null;
+    }
+}

rules/Php84/Rector/Class_/PropertyHookRector.php

@@ -9,8 +9,8 @@
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use Rector\Configuration\Parameter\FeatureFlags;
-use Rector\Doctrine\CodeQuality\Helper\SetterGetterFinder;
 use Rector\Php84\NodeFactory\PropertyHookFactory;
+use Rector\Php84\NodeFinder\SetterAndGetterFinder;
 use Rector\Rector\AbstractRector;
 use Rector\ValueObject\PhpVersionFeature;
 use Rector\VendorLocker\ParentClassMethodTypeOverrideGuard;
@@ -24,7 +24,7 @@
 final class PropertyHookRector extends AbstractRector implements MinPhpVersionInterface
 {
     public function __construct(
-        private readonly SetterGetterFinder $setterGetterFinder,
+        private readonly SetterAndGetterFinder $setterAndGetterFinder,
         private readonly PropertyHookFactory $propertyHookFactory,
         private readonly ParentClassMethodTypeOverrideGuard $parentClassMethodTypeOverrideGuard
     ) {
@@ -91,7 +91,10 @@ public function refactor(Node $node): ?Node
         foreach ($node->getProperties() as $property) {
             $propertyName = $this->getName($property);
 
-            $candidateClassMethods = $this->setterGetterFinder->findGetterAndSetterClassMethods($node, $propertyName);
+            $candidateClassMethods = $this->setterAndGetterFinder->findGetterAndSetterClassMethods(
+                $node,
+                $propertyName
+            );
 
             foreach ($candidateClassMethods as $candidateClassMethod) {
                 if (count((array) $candidateClassMethod->stmts) !== 1) {