[perf] [experiment] preload all node classes once at start

Author: TomasVotruba

scripts/src/Finder/NodeClassFinder.php

@@ -0,0 +1,42 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Scripts\Finder;
+
+require __DIR__ . '/../../../vendor/autoload.php';
+
+use Nette\Loaders\RobotLoader;
+use ReflectionClass;
+
+final class NodeClassFinder
+{
+    /**
+     * @return array<class-string<\PhpParser\Node>>
+     */
+    public static function find(): array
+    {
+        $robotLoader = new RobotLoader();
+        $robotLoader->acceptFiles = ['*.php'];
+
+        $phpParserNodeDirectory = __DIR__ . '/../../../vendor/nikic/php-parser/lib/PhpParser/Node/';
+        $robotLoader->addDirectory($phpParserNodeDirectory);
+
+        $robotLoader->setTempDirectory(sys_get_temp_dir() . '/node-classes');
+        $robotLoader->refresh();
+
+        /** @var array<class-string> $nodeClasses */
+        $nodeClasses = array_keys($robotLoader->getIndexedClasses());
+
+        $instantiableNodeClasses = array_filter($nodeClasses, function (string $nodeClass): bool {
+            $nodeClassReflection = new ReflectionClass($nodeClass);
+           if ($nodeClassReflection->isAbstract()) {
+               return false;
+           }
+
+           return ! $nodeClassReflection->isInterface();
+        });
+
+        return $instantiableNodeClasses;
+    }
+}

src/PhpParser/NodeTraverser/RectorNodeTraverser.php

@@ -9,7 +9,9 @@
 use PhpParser\NodeVisitor;
 use Rector\Configuration\ConfigurationRuleFilter;
 use Rector\Contract\Rector\RectorInterface;
+use Rector\Scripts\Finder\NodeClassFinder;
 use Rector\VersionBonding\PhpVersionedFilter;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\PhpParser\NodeTraverser\RectorNodeTraverserTest
@@ -63,22 +65,31 @@ public function refreshPhpRectors(array $rectors): void
      */
     public function getVisitorsForNode(Node $node): array
     {
-        $nodeClass = $node::class;
-
-        if (! isset($this->visitorsPerNodeClass[$nodeClass])) {
-            $this->visitorsPerNodeClass[$nodeClass] = [];
-            /** @var RectorInterface $visitor */
-            foreach ($this->visitors as $visitor) {
-                foreach ($visitor->getNodeTypes() as $nodeType) {
-                    if (is_a($nodeClass, $nodeType, true)) {
-                        $this->visitorsPerNodeClass[$nodeClass][] = $visitor;
-                        continue 2;
-                    }
-                }
-            }
-        }
-
-        return $this->visitorsPerNodeClass[$nodeClass];
+        Assert::true($this->areNodeVisitorsPrepared);
+
+        return $this->visitorsPerNodeClass[$node::class] ?? [];
+//
+//        $nodeClass = $node::class;
+//
+//        static $isACheckCounter = 0;
+//
+//        if (! isset($this->visitorsPerNodeClass[$nodeClass])) {
+//            $this->visitorsPerNodeClass[$nodeClass] = [];
+//            /** @var RectorInterface $visitor */
+//            foreach ($this->visitors as $visitor) {
+//                foreach ($visitor->getNodeTypes() as $nodeType) {
+//                    if (is_a($nodeClass, $nodeType, true)) {
+//                        ++$isACheckCounter;
+//
+//                        $this->visitorsPerNodeClass[$nodeClass][] = $visitor;
+//                        continue 2;
+//                    }
+//                }
+//            }
+//
+//            dump($isACheckCounter);
+//        }
+//        return $this->visitorsPerNodeClass[$nodeClass];
     }
 
     /**
@@ -97,6 +108,23 @@ private function prepareNodeVisitors(): void
         // filter by configuration
         $this->visitors = $this->configurationRuleFilter->filter($this->visitors);
 
+        static $counter = 0;
+
+        // 1. get all node non-interface, non-abstract classes
+        // 2. iterate through them
+        foreach (NodeClassFinder::find() as $nodeClass) {
+            /** @var RectorInterface $visitor */
+            foreach ($this->visitors as $visitor) {
+                foreach ($visitor->getNodeTypes() as $matchingNodeType) {
+                    if (is_a($nodeClass, $matchingNodeType, true)) {
+                        $this->visitorsPerNodeClass[$nodeClass][]  = $visitor;
+
+                        ++$counter;
+                    }
+                }
+            }
+        }
+
         $this->areNodeVisitorsPrepared = true;
     }
 }