[TypeDeclarationDocblocks] Allow override dummy array param on AddParamArrayDocblockFromAssignsParamToParamReferenceRector (#7375)

* [TypeDeclarationDocblocks] Allow override dummy array param on AddParamArrayDocblockFromAssignsParamToParamReferenceRector

* implemented 🎉

* re use NodeDocblockTypeDecorator

* re use NodeDocblockTypeDecorator

* Update rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockFromAssignsParamToParamReferenceRector.php

Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>

---------

Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>

Author: samsonasik

rules-tests/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockFromAssignsParamToParamReferenceRector/Fixture/override_dummy_array_param.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromAssignsParamToParamReferenceRector\Fixture;
+
+final class OverrideDummyArrayParam
+{
+    /**
+     * @param array $items
+     */
+    public function run(array &$items)
+    {
+        $items[] = 'John';
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromAssignsParamToParamReferenceRector\Fixture;
+
+final class OverrideDummyArrayParam
+{
+    /**
+     * @param string[] $items
+     */
+    public function run(array &$items)
+    {
+        $items[] = 'John';
+    }
+}
+
+?>

rules/TypeDeclarationDocblocks/NodeDocblockTypeDecorator.php

@@ -4,6 +4,7 @@
 
 namespace Rector\TypeDeclarationDocblocks;
 
+use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Property;
 use PHPStan\PhpDocParser\Ast\PhpDoc\ParamTagValueNode;
@@ -18,6 +19,7 @@
 use PHPStan\Type\NeverType;
 use PHPStan\Type\Type;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
+use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger;
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
 use Rector\Privatization\TypeManipulator\TypeNormalizer;
 use Rector\StaticTypeMapper\StaticTypeMapper;
@@ -28,13 +30,15 @@ public function __construct(
         private TypeNormalizer $typeNormalizer,
         private StaticTypeMapper $staticTypeMapper,
         private DocBlockUpdater $docBlockUpdater,
+        private PhpDocTypeChanger $phpDocTypeChanger
     ) {
     }
 
     public function decorateGenericIterableParamType(
         Type $type,
         PhpDocInfo $phpDocInfo,
         ClassMethod $classMethod,
+        Param $param,
         string $parameterName
     ): bool {
         if ($this->isBareMixedType($type)) {
@@ -50,9 +54,7 @@ public function decorateGenericIterableParamType(
             return false;
         }
 
-        $paramTagValueNode = new ParamTagValueNode($typeNode, false, '$' . $parameterName, '', false);
-
-        $this->addTagValueNodeAndUpdatePhpDocInfo($phpDocInfo, $paramTagValueNode, $classMethod);
+        $this->phpDocTypeChanger->changeParamType($classMethod, $phpDocInfo, $normalizedType, $param, $parameterName);
 
         return true;
     }

rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddParamArrayDocblockFromAssignsParamToParamReferenceRector.php

@@ -14,6 +14,7 @@
 use Rector\Rector\AbstractRector;
 use Rector\TypeDeclarationDocblocks\NodeDocblockTypeDecorator;
 use Rector\TypeDeclarationDocblocks\NodeFinder\ArrayDimFetchFinder;
+use Rector\TypeDeclarationDocblocks\TagNodeAnalyzer\UsefulArrayTagNodeAnalyzer;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -25,6 +26,7 @@ final class AddParamArrayDocblockFromAssignsParamToParamReferenceRector extends
     public function __construct(
         private readonly PhpDocInfoFactory $phpDocInfoFactory,
         private readonly ArrayDimFetchFinder $arrayDimFetchFinder,
+        private readonly UsefulArrayTagNodeAnalyzer $usefulArrayTagNodeAnalyzer,
         private readonly NodeDocblockTypeDecorator $nodeDocblockTypeDecorator,
     ) {
     }
@@ -101,7 +103,9 @@ public function refactor(Node $node): ?Node
             $paramTagValueNode = $phpDocInfo->getParamTagValueByName($paramName);
 
             // already defined, lets skip it
-            if ($paramTagValueNode instanceof ParamTagValueNode) {
+            if ($this->usefulArrayTagNodeAnalyzer->isUsefulArrayTag(
+                $paramTagValueNode
+            )) {
                 continue;
             }
 
@@ -114,11 +118,11 @@ public function refactor(Node $node): ?Node
 
             $assignedExprType = $this->getType($exprs[0]);
             $iterableType = new ArrayType(new MixedType(), $assignedExprType);
-
             $hasParamTypeChanged = $this->nodeDocblockTypeDecorator->decorateGenericIterableParamType(
                 $iterableType,
                 $phpDocInfo,
                 $node,
+                $param,
                 $paramName
             );
 

rules/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector.php

@@ -127,6 +127,7 @@ public function refactor(Node $node): ?Node
                     $resolvedParameterType,
                     $classMethodPhpDocInfo,
                     $classMethod,
+                    $param,
                     $parameterName
                 );
 

rules/TypeDeclarationDocblocks/TagNodeAnalyzer/UsefulArrayTagNodeAnalyzer.php

@@ -4,18 +4,19 @@
 
 namespace Rector\TypeDeclarationDocblocks\TagNodeAnalyzer;
 
+use PHPStan\PhpDocParser\Ast\PhpDoc\ParamTagValueNode;
 use PHPStan\PhpDocParser\Ast\PhpDoc\ReturnTagValueNode;
 use PHPStan\PhpDocParser\Ast\Type\IdentifierTypeNode;
 
 final class UsefulArrayTagNodeAnalyzer
 {
-    public function isUsefulArrayTag(?ReturnTagValueNode $returnTagValueNode): bool
+    public function isUsefulArrayTag(null|ReturnTagValueNode|ParamTagValueNode $tagValueNode): bool
     {
-        if (! $returnTagValueNode instanceof ReturnTagValueNode) {
+        if (! $tagValueNode instanceof ReturnTagValueNode && ! $tagValueNode instanceof ParamTagValueNode) {
             return false;
         }
 
-        $type = $returnTagValueNode->type;
+        $type = $tagValueNode->type;
         if (! $type instanceof IdentifierTypeNode) {
             return true;
         }