[CodeQuality] Allow compare int and int<0, max> on UseIdenticalOverEqualWithSameTypeRector (#7416)

* [CodeQuality] Allow compare int and int<0, max> on UseIdenticalOverEqualWithSameTypeRector

* [ci-review] Rector Rectify

* fixture fix

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: samsonasik

rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/identical_integer.php.inc

@@ -0,0 +1,51 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector\Fixture;
+
+final class IdenticalInteger
+{
+    public function equal()
+    {
+        if ($this->getValue() == 1) {
+            return 'yes';
+        }
+
+        return 'no';
+    }
+
+    /**
+     * @return int<0, max>
+     */
+    private function getValue(): int
+    {
+        return 1;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector\Fixture;
+
+final class IdenticalInteger
+{
+    public function equal()
+    {
+        if ($this->getValue() === 1) {
+            return 'yes';
+        }
+
+        return 'no';
+    }
+
+    /**
+     * @return int<0, max>
+     */
+    private function getValue(): int
+    {
+        return 1;
+    }
+}
+
+?>

rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php

@@ -89,6 +89,10 @@ public function refactor(Node $node): ?Node
             return $this->processIdenticalOrNotIdentical($node);
         }
 
+        if ($leftStaticType->isInteger()->yes() && $rightStaticType->isInteger()->yes()) {
+            return $this->processIdenticalOrNotIdentical($node);
+        }
+
         // different types
         if (! $leftStaticType->equals($rightStaticType)) {
             return null;

rules/TypeDeclaration/PhpDocParser/TypeExpressionFromVarTagResolver.php

@@ -110,7 +110,7 @@ public function resolveTypeExpressionFromVarTag(TypeNode $typeNode, Variable $va
     private function generateOrExpression(array $unionExpressions)
     {
         $booleanOr = new BooleanOr($unionExpressions[0], $unionExpressions[1]);
-        if (count($unionExpressions) == 2) {
+        if (count($unionExpressions) === 2) {
             return $booleanOr;
         }
 
@@ -125,7 +125,7 @@ private function generateOrExpression(array $unionExpressions)
     private function generateAndExpression(array $intersectionExpressions)
     {
         $booleanAnd = new BooleanAnd($intersectionExpressions[0], $intersectionExpressions[1]);
-        if (count($intersectionExpressions) == 2) {
+        if (count($intersectionExpressions) === 2) {
             return $booleanAnd;
         }
 

src/Configuration/OnlyRuleResolver.php

@@ -48,7 +48,7 @@ public function resolve(string $rule): string
         }
 
         $matching = array_unique($matching);
-        if (count($matching) == 1) {
+        if (count($matching) === 1) {
             return $matching[0];
         }