[CodeQuality] Skip @Final doc with public class constant on ConvertStaticToSelfRector

Author: samsonasik

rules-tests/CodeQuality/Rector/Class_/ConvertStaticToSelfRector/Fixture/skip_final_doc_class_constant.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Class_\ConvertStaticToSelfRector\Fixture;
+
+class SkipFinalDocClassConstant
+{
+    /**
+     * @final
+     */
+    public const BAR = 1;
+
+    public function run()
+    {
+        static::BAR;
+    }
+}

rules/CodeQuality/Rector/Class_/ConvertStaticToSelfRector.php

@@ -16,8 +16,10 @@
 use PHPStan\Reflection\ClassReflection;
 use Rector\Configuration\Parameter\FeatureFlags;
 use Rector\Enum\ObjectReference;
+use Rector\Php\PhpVersionProvider;
 use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
+use Rector\ValueObject\PhpVersionFeature;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -31,6 +33,10 @@
  */
 final class ConvertStaticToSelfRector extends AbstractRector
 {
+    public function __construct(private readonly PhpVersionProvider $phpVersionProvider)
+    {
+    }
+
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition('Change `static::*` to `self::*` on final class or private static members', [
@@ -163,9 +169,25 @@ private function shouldSkip(
         }
 
         if (! $isFinal) {
-            $memberIsFinal = $reflection instanceof ClassConstantReflection
-                ? $reflection->isFinal()
-                : $reflection->isFinalByKeyword()->yes();
+            if ($reflection instanceof ClassConstantReflection) {
+                // Get the native ReflectionClassConstant
+                $declaringClass = $reflection->getDeclaringClass();
+                $nativeReflectionClass = $declaringClass->getNativeReflection();
+                $constantName = $reflection->getName();
+
+                if ($this->phpVersionProvider->isAtLeastPhpVersion(PhpVersionFeature::FINAL_CLASS_CONSTANTS)) {
+                    // PHP 8.1+
+                    $nativeReflection = $nativeReflectionClass->getReflectionConstant($constantName);
+                    $memberIsFinal = $nativeReflection instanceof \ReflectionClassConstant
+                        ? $nativeReflection->isFinal()
+                        : false;
+                } else {
+                    // On PHP < 8.1, class constants can't be final
+                    $memberIsFinal = false;
+                }
+            } else {
+                $memberIsFinal = $reflection->isFinalByKeyword()->yes();
+            }
 
             // Final native members can be safely converted
             if ($memberIsFinal) {