skip negated

Author: samsonasik

rules-tests/DeadCode/Rector/Ternary/RemoveUselessTernaryRector/Fixture/skip_negated_cond.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class SkipNegatedCond
+{
+    public function go(bool $value)
+    {
+        return ! $value ?: false;
+    }
+}

rules/DeadCode/Rector/Ternary/RemoveUselessTernaryRector.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Array_;
+use PhpParser\Node\Expr\BooleanNot;
 use PhpParser\Node\Expr\Ternary;
 use PhpParser\Node\Scalar\Int_;
 use PHPStan\Type\ArrayType;
@@ -65,6 +66,12 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        // if condition is negated
+        // switch negated ternary condition via SwitchNegatedTernaryRector for that
+        if ($node->cond instanceof BooleanNot) {
+            return null;
+        }
+
         $nativeType = $this->nodeTypeResolver->getNativeType($node->cond);
         if ($nativeType instanceof BooleanType && $this->valueResolver->isFalse($node->else)) {
             return $node->cond;