[CodeQuality] Skip has object inside array on UseIdenticalOverEqualWithSameTypeRector (#7418)

* [CodeQuality] Skip has object inside array on UseIdenticalOverEqualWithSameTypeRector

* [CodeQuality] Skip has object inside array on UseIdenticalOverEqualWithSameTypeRector

* Fix

Author: samsonasik

rules-tests/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_objects_inside_array.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector\Fixture;
+
+/**
+ * @see https://3v4l.org/qU0Ou
+ */
+class SkipObjectsInsideArray
+{
+    public function run(\stdClass $firstValue, \stdClass $secondValue)
+    {
+        return [$firstValue] == [$secondValue];
+    }
+}

rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php

@@ -16,6 +16,7 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
+use PHPStan\Type\TypeTraverser;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -78,7 +79,7 @@ public function refactor(Node $node): ?Node
         $rightStaticType = $this->nodeTypeResolver->getNativeType($node->right);
 
         // objects can be different by content
-        if (! $leftStaticType->isObject()->no() || ! $rightStaticType->isObject()->no()) {
+        if ($this->hasObjectType($leftStaticType) || $this->hasObjectType($rightStaticType)) {
             return null;
         }
 
@@ -96,6 +97,21 @@ public function refactor(Node $node): ?Node
         return $this->processIdenticalOrNotIdentical($node);
     }
 
+    private function hasObjectType(Type $type): bool
+    {
+        $hasObjecType = false;
+        TypeTraverser::map($type, function (Type $type, callable $traverseCallback) use (&$hasObjecType): Type {
+            // maybe has object type? mark as object type
+            if (! $type->isObject()->no()) {
+                $hasObjecType = true;
+            }
+
+            return $traverseCallback($type);
+        });
+
+        return $hasObjecType;
+    }
+
     private function normalizeScalarType(Type $type): Type
     {
         if ($type->isString()->yes()) {