[CodeQuality][Php84] Handle crash on ForeachToArrayFindRector+OptionalParametersAfterRequiredRector (#7033)

* [CodeQuality][Php84] Handle crash on ForeachToArrayFindRector+OptionalParametersAfterRequiredRector

* rec

* rec

* fix

* [ci-review] Rector Rectify

* Fix

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: samsonasik

rules/CodeQuality/Rector/ClassMethod/OptionalParametersAfterRequiredRector.php

@@ -89,22 +89,19 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ClassMethod|Function_|null|New_|MethodCall|StaticCall|FuncCall
     {
-        $scope = ScopeFetcher::fetch($node);
-
         if ($node instanceof ClassMethod || $node instanceof Function_) {
-            return $this->refactorClassMethodOrFunction($node, $scope);
+            return $this->refactorClassMethodOrFunction($node);
         }
 
         if ($node instanceof New_) {
-            return $this->refactorNew($node, $scope);
+            return $this->refactorNew($node);
         }
 
-        return $this->refactorMethodCallOrFuncCall($node, $scope);
+        return $this->refactorMethodCallOrFuncCall($node);
     }
 
     private function refactorClassMethodOrFunction(
-        ClassMethod|Function_ $node,
-        Scope $scope
+        ClassMethod|Function_ $node
     ): ClassMethod|Function_|null {
         if ($node->params === []) {
             return null;
@@ -114,6 +111,7 @@ private function refactorClassMethodOrFunction(
             return null;
         }
 
+        $scope = ScopeFetcher::fetch($node);
         if ($node instanceof ClassMethod) {
             $reflection = $this->reflectionResolver->resolveMethodReflectionFromClassMethod($node, $scope);
         } else {
@@ -138,7 +136,7 @@ private function refactorClassMethodOrFunction(
         return $node;
     }
 
-    private function refactorNew(New_ $new, Scope $scope): ?New_
+    private function refactorNew(New_ $new): ?New_
     {
         if ($new->args === []) {
             return null;
@@ -153,6 +151,7 @@ private function refactorNew(New_ $new, Scope $scope): ?New_
             return null;
         }
 
+        $scope = ScopeFetcher::fetch($new);
         $expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($methodReflection, $new, $scope);
         if ($expectedArgOrParamOrder === null) {
             return null;
@@ -164,8 +163,7 @@ private function refactorNew(New_ $new, Scope $scope): ?New_
     }
 
     private function refactorMethodCallOrFuncCall(
-        MethodCall|StaticCall|FuncCall $node,
-        Scope $scope
+        MethodCall|StaticCall|FuncCall $node
     ): MethodCall|StaticCall|FuncCall|null {
         if ($node->isFirstClassCallable()) {
             return null;
@@ -176,6 +174,7 @@ private function refactorMethodCallOrFuncCall(
             return null;
         }
 
+        $scope = ScopeFetcher::fetch($node);
         $expectedArgOrParamOrder = $this->resolveExpectedArgParamOrderIfDifferent($reflection, $node, $scope);
         if ($expectedArgOrParamOrder === null) {
             return null;
@@ -215,6 +214,7 @@ private function resolveExpectedArgParamOrderIfDifferent(
             return null;
         }
 
+        $scope = ScopeFetcher::fetch($node);
         $parametersAcceptor = ParametersAcceptorSelectorVariantsWrapper::select($reflection, $node, $scope);
         $expectedParameterReflections = $this->requireOptionalParamResolver->resolveFromParametersAcceptor(
             $parametersAcceptor

rules/Php84/Rector/Class_/DeprecatedAnnotationToDeprecatedAttributeRector.php

@@ -157,8 +157,9 @@ private function createAttributeGroup(string $annotationValue): AttributeGroup
                         value: new String_($annotationValue, [
                             AttributeKey::KIND => String_::KIND_NOWDOC,
                             AttributeKey::DOC_LABEL => 'TXT',
-                    ]))]
-                )
+                        ])
+                    )]
+                ),
             ]);
         }
 

src/ProcessAnalyzer/RectifiedAnalyzer.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt;
 use Rector\Contract\Rector\RectorInterface;
+use Rector\NodeAnalyzer\ScopeAnalyzer;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 
 /**
@@ -17,8 +18,13 @@
  *      - just re-printed but token start still >= 0
  *      - has above node skipped traverse children on current rule
  */
-final class RectifiedAnalyzer
+final readonly class RectifiedAnalyzer
 {
+    public function __construct(
+        private ScopeAnalyzer $scopeAnalyzer
+    ) {
+    }
+
     /**
      * @param class-string<RectorInterface> $rectorClass
      */
@@ -81,10 +87,10 @@ private function isJustReprintedOverlappedTokenStart(Node $node, ?Node $original
             return true;
         }
 
-        if ($node instanceof Stmt) {
-            return ! in_array(AttributeKey::SCOPE, array_keys($node->getAttributes()), true);
+        if (! $this->scopeAnalyzer->isRefreshable($node)) {
+            return false;
         }
 
-        return $node->getAttributes() === [];
+        return ! in_array(AttributeKey::SCOPE, array_keys($node->getAttributes()), true);
     }
 }

tests/Issues/ScopeNotAvailable/FixtureForeachToArrayParam/fixture.php.inc

@@ -0,0 +1,55 @@
+<?php
+
+namespace Rector\Tests\Issues\ScopeNotAvailable\FixtureForeachToArrayParam;
+
+use App\Entity\Url;
+
+class Fixture
+{
+    /**
+     * @param array<Url> $urls
+     */
+    public function create(array $urls, string $hash): ?Url
+    {
+        if (0 === \count($urls)) {
+            $url = new Url();
+        } else {
+            $url = null;
+            foreach ($urls as $urlToCheck) {
+                if ($urlToCheck->getPathHash() === $hash) {
+                    $url = $urlToCheck;
+                    break;
+                }
+            }
+        }
+
+        return $url;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Issues\ScopeNotAvailable\FixtureForeachToArrayParam;
+
+use App\Entity\Url;
+
+class Fixture
+{
+    /**
+     * @param array<Url> $urls
+     */
+    public function create(array $urls, string $hash): ?Url
+    {
+        if (0 === \count($urls)) {
+            $url = new Url();
+        } else {
+            $url = array_find($urls, fn($urlToCheck) => $urlToCheck->getPathHash() === $hash);
+        }
+
+        return $url;
+    }
+}
+
+?>

tests/Issues/ScopeNotAvailable/ForeachToArrayParamTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Issues\ScopeNotAvailable;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class ForeachToArrayParamTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/FixtureForeachToArrayParam');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/foreach_to_array_param.php';
+    }
+}

tests/Issues/ScopeNotAvailable/config/foreach_to_array_param.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\CodeQuality\Rector\ClassMethod\OptionalParametersAfterRequiredRector;
+use Rector\Config\RectorConfig;
+use Rector\Php84\Rector\Foreach_\ForeachToArrayFindRector;
+use Rector\ValueObject\PhpVersion;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([ForeachToArrayFindRector::class, OptionalParametersAfterRequiredRector::class]);
+
+    $rectorConfig->phpVersion(PhpVersion::PHP_84);
+};