add simple test to allow node change type

Author: TomasVotruba

phpstan.neon

@@ -433,6 +433,11 @@ parameters:
                 - rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php
                 - rules/Php81/Enum/AttributeName.php
 
+        -
+            identifier: symplify.seeAnnotationToTest
+            paths:
+                - tests/PhpParser/NodeTraverser/StopTraverseOnTypeChange/Class_
+
         # deprecated rule
         - '#Rule Rector\\Php81\\Rector\\Array_\\FirstClassCallableRector must implements Rector\\VersionBonding\\Contract\\MinPhpVersionInterface#'
         - '#Register "Rector\\Php81\\Rector\\Array_\\FirstClassCallableRector" service to "php81\.php" config set#'

src/PhpParser/NodeTraverser/AbstractImmutableNodeTraverser.php

@@ -101,6 +101,7 @@ protected function traverseNode(Node $node): void
             $traverseChildren = true;
             $visitorIndex = -1;
             $currentNodeVisitors = $this->getVisitorsForNode($subNode);
+
             foreach ($currentNodeVisitors as $visitorIndex => $visitor) {
                 $return = $visitor->enterNode($subNode);
                 if ($return !== null) {
@@ -185,6 +186,7 @@ protected function traverseArray(array $nodes): array
             $traverseChildren = true;
             $visitorIndex = -1;
             $currentNodeVisitors = $this->getVisitorsForNode($node);
+
             foreach ($currentNodeVisitors as $visitorIndex => $visitor) {
                 $return = $visitor->enterNode($node);
                 if ($return !== null) {

src/PhpParser/NodeTraverser/RectorNodeTraverser.php

@@ -95,6 +95,7 @@ private function prepareNodeVisitors(): void
 
         // filer out by version
         $this->visitors = $this->phpVersionedFilter->filter($this->rectors);
+
         // filter by configuration
         $this->visitors = $this->configurationRuleFilter->filter($this->visitors);
 

tests/PhpParser/NodeTraverser/StopTraverseOnTypeChange/Class_/RuleChangingClassToTraitRector.php

@@ -1,29 +1,36 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Rector\Tests\PhpParser\NodeTraverser\StopTraverseOnTypeChange\Class_;
 
 use PhpParser\Node;
+use PhpParser\Node\Name;
+use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\Trait_;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
 final class RuleChangingClassToTraitRector extends AbstractRector
 {
-
     public function getRuleDefinition(): RuleDefinition
     {
+        return new RuleDefinition('Change node from class to trait', []);
     }
 
     public function getNodeTypes(): array
     {
-        return [Node\Stmt\Class_::class];
+        return [Class_::class];
     }
 
     /**
-     * @param Node\Stmt\Class_ $node
-     * @return Node\Stmt\Trait_
+     * @param Class_ $node
      */
-    public function refactor(Node $node)
+    public function refactor(Node $node): Trait_
     {
-        return new Node\Stmt\Trait_('SomeTrait');
+        $trait = new Trait_('SomeTrait');
+        $trait->namespacedName = new Name('SomeNamespace\SomeTrait');
+
+        return $trait;
     }
 }

tests/PhpParser/NodeTraverser/StopTraverseOnTypeChange/Class_/RuleCheckingClassRector.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Rector\Tests\PhpParser\NodeTraverser\StopTraverseOnTypeChange\Class_;
 
 use PhpParser\Node;
@@ -10,9 +12,9 @@
 
 final class RuleCheckingClassRector extends AbstractRector
 {
-
     public function getRuleDefinition(): RuleDefinition
     {
+        return new RuleDefinition('Make sure input is class', []);
     }
 
     public function getNodeTypes(): array
@@ -24,7 +26,7 @@ public function getNodeTypes(): array
      * @param Class_ $node
      * @return Class_
      */
-    public function refactor(Node $node)
+    public function refactor(Node $node): Node
     {
         Assert::isInstanceOf($node, Class_::class);
 

tests/PhpParser/NodeTraverser/StopTraverseOnTypeChange/Fixture/SimpleClass.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\PhpParser\NodeTraverser\StopTraverseOnTypeChange\Fixture;
+
+final class SimpleClass
+{
+}

tests/PhpParser/NodeTraverser/StopTraverseOnTypeChange/StopTraverseOnTypeChangeTest.php

@@ -6,36 +6,45 @@
 
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\Trait_;
-use Rector\Application\Provider\CurrentFileProvider;
+use PhpParser\NodeFinder;
 use Rector\PhpParser\NodeTraverser\RectorNodeTraverser;
 use Rector\Testing\PHPUnit\AbstractLazyTestCase;
+use Rector\Testing\TestingParser\TestingParser;
 use Rector\Tests\PhpParser\NodeTraverser\StopTraverseOnTypeChange\Class_\RuleChangingClassToTraitRector;
 use Rector\Tests\PhpParser\NodeTraverser\StopTraverseOnTypeChange\Class_\RuleCheckingClassRector;
 
 final class StopTraverseOnTypeChangeTest extends AbstractLazyTestCase
 {
     private RectorNodeTraverser $rectorNodeTraverser;
 
+    private TestingParser $testingParser;
+
     protected function setUp(): void
     {
+        parent::setUp();
+
         $this->rectorNodeTraverser = $this->make(RectorNodeTraverser::class);
 
         $this->rectorNodeTraverser->refreshPhpRectors([
             $this->make(RuleChangingClassToTraitRector::class),
-            $this->make(RuleCheckingClassRector::class)
+            $this->make(RuleCheckingClassRector::class),
         ]);
 
-        $currentFileProvider = $this->make(CurrentFileProvider::class);
-
-        // @todo
-        // $currentFileProvider->setFile();
+        $this->testingParser = $this->make(TestingParser::class);
     }
 
     public function testGetVisitorsForNodeWhenNoVisitorsAvailable(): void
     {
-        $class = new Class_('test');
+        // must be cloned + Scope set to allow node replacement
+        $nodes = $this->testingParser->parseFileToDecoratedNodes(__DIR__ . '/Fixture/SimpleClass.php');
+
+        $changedNodes = $this->rectorNodeTraverser->traverse($nodes);
+
+        $nodeFinder = new NodeFinder();
+        $classes = $nodeFinder->findInstanceOf($changedNodes, Class_::class);
+        $this->assertCount(0, $classes);
 
-        $changedNodes = $this->rectorNodeTraverser->traverse([$class]);
-        $this->assertContainsOnlyInstancesOf(Trait_::class, $changedNodes);
+        $traits = $nodeFinder->findInstanceOf($changedNodes, Trait_::class);
+        $this->assertCount(1, $traits);
     }
 }