phpstan

Author: samsonasik

rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/FullyQualifiedNameClassNameImportSkipVoter.php

@@ -29,6 +29,7 @@ public function __construct(
     public function shouldSkip(File $file, FullyQualifiedObjectType $fullyQualifiedObjectType, Node $node): bool
     {
         // "new X" or "X::static()"
+        /** @var array<string, string> $shortNamesToFullyQualifiedNames */
         $shortNamesToFullyQualifiedNames = $this->shortNameResolver->resolveFromFile($file);
         $loweredShortNameFullyQualified = $fullyQualifiedObjectType->getShortNameLowered();
 

rules/CodingStyle/ClassNameImport/ShortNameResolver.php

@@ -143,7 +143,11 @@ private function resolveForStmts(array $stmts): array
         });
 
         $docBlockShortNamesToFullyQualifiedNames = $this->resolveFromStmtsDocBlocks($stmts);
-        return [...$shortNamesToFullyQualifiedNames, ...$docBlockShortNamesToFullyQualifiedNames];
+        /**
+         * @var array<string, string> $result
+         */
+        $result = [...$shortNamesToFullyQualifiedNames, ...$docBlockShortNamesToFullyQualifiedNames];
+        return $result;
     }
 
     /**

rules/MockeryToProphecy/Rector/ClassMethod/MockeryCreateMockToProphizeRector.php

@@ -102,7 +102,9 @@ private function replaceMockCreationsAndCollectVariableNames(ClassMethod $classM
 
             $collectedVariableTypesByNames = $this->mockVariableCollector->collectMockVariableName($node);
 
-            $this->mockVariableTypesByNames = [...$this->mockVariableTypesByNames, ...$collectedVariableTypesByNames];
+            /** @var array<string, class-string> $result */
+            $result = [...$this->mockVariableTypesByNames, ...$collectedVariableTypesByNames];
+            $this->mockVariableTypesByNames = $result;
 
             $parentNode = $node->getAttribute(AttributeKey::PARENT_NODE);
             if ($parentNode instanceof Arg) {

src/Configuration/RenamedClassesDataCollector.php

@@ -28,7 +28,9 @@ public function hasOldClass(string $oldClass): bool
      */
     public function addOldToNewClasses(array $oldToNewClasses): void
     {
-        $this->oldToNewClasses = [...$this->oldToNewClasses, ...$oldToNewClasses];
+        /** @var array<string, string> $oldToNewClasses */
+        $oldToNewClasses = [...$this->oldToNewClasses, ...$oldToNewClasses];
+        $this->oldToNewClasses = $oldToNewClasses;
     }
 
     /**

src/NonPhpFile/Rector/RenameClassNonPhpRector.php

@@ -139,7 +139,9 @@ private function addDoubleSlahed(array $classRenames): array
      */
     private function getRenameClasses(): array
     {
-        return [...$this->renameClasses, ...$this->renamedClassesDataCollector->getOldToNewClasses()];
+        /** @var array<string, string> $renameClasses */
+        $renameClasses = [...$this->renameClasses, ...$this->renamedClassesDataCollector->getOldToNewClasses()];
+        return $renameClasses;
     }
 
     private function createOldClassRegex(string $oldClass): string