[ci-review] Rector Rectify

Author: actions-user

rules/TypeDeclaration/NodeAnalyzer/ClassMethodAndPropertyAnalyzer.php

@@ -42,18 +42,18 @@ public function hasPropertyFetchReturn(ClassMethod $classMethod, string $propert
         return $this->nodeNameResolver->isName($return->expr, $propertyName);
     }
 
-    public function hasOnlyPropertyAssign(ClassMethod $classMethod, string $propertyName): bool
+    public function hasOnlyPropertyAssign(ClassMethod $classMethod): bool
     {
         $stmts = (array) $classMethod->stmts;
         if (count($stmts) !== 1) {
             return false;
         }
 
         $onlyClassMethodStmt = $stmts[0];
-        return $this->isLocalPropertyVariableAssign($onlyClassMethodStmt, $propertyName);
+        return $this->isLocalPropertyVariableAssign($onlyClassMethodStmt);
     }
 
-    public function hasPropertyAssignWithReturnThis(ClassMethod $classMethod, string $propertyName): bool
+    public function hasPropertyAssignWithReturnThis(ClassMethod $classMethod): bool
     {
         $stmts = (array) $classMethod->stmts;
         if (count($stmts) !== 2) {
@@ -63,7 +63,7 @@ public function hasPropertyAssignWithReturnThis(ClassMethod $classMethod, string
         $possibleAssignStmt = $stmts[0];
         $possibleReturnThis = $stmts[1];
 
-        if (! $this->isLocalPropertyVariableAssign($possibleAssignStmt, $propertyName)) {
+        if (! $this->isLocalPropertyVariableAssign($possibleAssignStmt)) {
             return false;
         }
 
@@ -80,7 +80,7 @@ public function hasPropertyAssignWithReturnThis(ClassMethod $classMethod, string
         return $this->nodeNameResolver->isName($returnExpr, 'this');
     }
 
-    private function isLocalPropertyVariableAssign(Stmt $onlyClassMethodStmt, string $propertyName): bool
+    private function isLocalPropertyVariableAssign(Stmt $onlyClassMethodStmt): bool
     {
         if (! $onlyClassMethodStmt instanceof Expression) {
             return false;

rules/TypeDeclaration/TypeInferer/PropertyTypeInferer/SetterTypeDeclarationPropertyTypeInferer.php

@@ -24,11 +24,10 @@ public function __construct(
 
     public function inferProperty(Property $property, Class_ $class): ?Type
     {
-        /** @var string $propertyName */
-        $propertyName = $this->nodeNameResolver->getName($property);
+        $this->nodeNameResolver->getName($property);
 
         foreach ($class->getMethods() as $classMethod) {
-            if (! $this->classMethodAndPropertyAnalyzer->hasOnlyPropertyAssign($classMethod, $propertyName)) {
+            if (! $this->classMethodAndPropertyAnalyzer->hasOnlyPropertyAssign($classMethod)) {
                 continue;
             }
 

rules/Unambiguous/Rector/Class_/RemoveReturnThisFromSetterClassMethodRector.php

@@ -101,7 +101,7 @@ public function refactor(Node $node): ?Class_
                 continue;
             }
 
-            if (! $this->classMethodAndPropertyAnalyzer->hasPropertyAssignWithReturnThis($classMethod, $paramName)) {
+            if (! $this->classMethodAndPropertyAnalyzer->hasPropertyAssignWithReturnThis($classMethod)) {
                 continue;
             }