[CodeQuality] Skip Assign Op on ternary on SimplifyUselessVariableRector (#6913)

Author: samsonasik

rules-tests/CodeQuality/Rector/FunctionLike/SimplifyUselessVariableRector/Fixture/skip_ternary.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\FunctionLike\SimplifyUselessVariableRector\Fixture;
+
+class SkipTernary
+{
+    public function run(?string $maybe, string $part): string
+    {
+       $address = $maybe;
+       $address .= $address ? ' - ' . $part : $part;
+
+       return $address;
+    }
+}

rules/CodeQuality/Rector/FunctionLike/SimplifyUselessVariableRector.php

@@ -8,6 +8,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\AssignOp;
+use PhpParser\Node\Expr\Ternary;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Expression;
@@ -193,6 +194,10 @@ private function shouldSkipStmt(Return_ $return, Stmt $previousStmt): bool
             return true;
         }
 
+        if ($previousNode instanceof AssignOp && $previousNode->expr instanceof Ternary) {
+            return true;
+        }
+
         $variable = $return->expr;
         // is the same variable
         if (! $this->nodeComparator->areNodesEqual($previousNode->var, $variable)) {