[ci-review] Rector Rectify

Author: actions-user

rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php

@@ -66,7 +66,7 @@ public function getNodeTypes(): array
     public function refactor(Node $node): ?FuncCall
     {
         $identicals = $this->betterNodeFinder->findInstanceOf($node, Identical::class);
-        $equals = $this->betterNodeFinder->findInstanceOf($node, Equal::class);
+        $this->betterNodeFinder->findInstanceOf($node, Equal::class);
 
         if (! $this->isEqualOrIdentical($node->right)) {
             return null;

rules/CodingStyle/Rector/Stmt/NewlineAfterStatementRector.php

@@ -186,7 +186,7 @@ private function resolveRangeLineFromComment(
      */
     private function hasNoComment(?array $comments): bool
     {
-        return $comments === null || $comments === [];
+        return in_array($comments, [null, []], true);
     }
 
     private function shouldSkip(Stmt $stmt): bool

rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php

@@ -82,7 +82,7 @@ public function getNodeTypes(): array
     public function refactor(Node $node): null|ClassMethod|Function_
     {
         $stmts = $node->stmts;
-        if ($stmts === null || $stmts === []) {
+        if (in_array($stmts, [null, []], true)) {
             return null;
         }
 

rules/DeadCode/Rector/ClassMethod/RemoveUselessAssignFromPropertyPromotionRector.php

@@ -66,7 +66,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if ($node->stmts === null || $node->stmts == []) {
+        if (in_array($node->stmts, [null, []], true)) {
             return null;
         }
 

rules/DeadCode/Rector/FunctionLike/RemoveDeadReturnRector.php

@@ -74,7 +74,7 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if ($node->stmts === [] || $node->stmts === null) {
+        if (in_array($node->stmts, [[], null], true)) {
             return null;
         }
 

rules/Php70/EregToPcreTransformer.php

@@ -136,7 +136,7 @@ private function _ere2pcre(string $content, int $i): array
                 $r[$rr] .= '[' . $cls . ']';
             } elseif ($char === ')') {
                 break;
-            } elseif ($char === '*' || $char === '+' || $char === '?') {
+            } elseif (in_array($char, ['*', '+', '?'], true)) {
                 throw new InvalidEregException('unescaped metacharacter "' . $char . '"');
             } elseif ($char === '{') {
                 if ($i + 1 < $l && \str_contains('0123456789', $content[$i + 1])) {
@@ -146,7 +146,7 @@ private function _ere2pcre(string $content, int $i): array
                 }
             } elseif ($char === '.') {
                 $r[$rr] .= $char;
-            } elseif ($char === '^' || $char === '$') {
+            } elseif (in_array($char, ['^', '$'], true)) {
                 $r[$rr] .= $char;
                 ++$i;
                 continue;
@@ -177,7 +177,7 @@ private function _ere2pcre(string $content, int $i): array
 
             // piece after the atom (only ONE of them is possible)
             $char = $content[$i];
-            if ($char === '*' || $char === '+' || $char === '?') {
+            if (in_array($char, ['*', '+', '?'], true)) {
                 $r[$rr] .= $char;
                 ++$i;
             } elseif ($char === '{') {

rules/Php81/Rector/ClassMethod/NewInInitializerRector.php

@@ -81,7 +81,7 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if ($node->stmts === null || $node->stmts === []) {
+        if (in_array($node->stmts, [null, []], true)) {
             return null;
         }
 
@@ -194,7 +194,7 @@ private function processPropertyPromotion(Class_ $class, Param $param, string $p
     private function matchConstructorParams(ClassMethod $classMethod): array
     {
         // skip empty constructor assigns, as we need those here
-        if ($classMethod->stmts === null || $classMethod->stmts === []) {
+        if (in_array($classMethod->stmts, [null, []], true)) {
             return [];
         }
 

rules/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector.php

@@ -267,7 +267,7 @@ private function shouldSkipParentClassMethod(ClassReflection $parentClassReflect
         }
 
         // has any stmts?
-        if ($parentClassMethod->stmts === null || $parentClassMethod->stmts === []) {
+        if (in_array($parentClassMethod->stmts, [null, []], true)) {
             return true;
         }
 

rules/TypeDeclaration/Rector/ClassMethod/NumericReturnTypeFromStrictReturnsRector.php

@@ -136,7 +136,7 @@ private function shouldSkip(ClassMethod|Function_ $functionLike, Scope $scope):
         }
 
         // empty, nothing to find
-        if ($functionLike->stmts === null || $functionLike->stmts === []) {
+        if (in_array($functionLike->stmts, [null, []], true)) {
             return true;
         }
 

rules/TypeDeclaration/Rector/ClassMethod/NumericReturnTypeFromStrictScalarReturnsRector.php

@@ -129,7 +129,7 @@ private function shouldSkip(ClassMethod|Function_ $functionLike, Scope $scope):
         }
 
         // empty, nothing to find
-        if ($functionLike->stmts === null || $functionLike->stmts === []) {
+        if (in_array($functionLike->stmts, [null, []], true)) {
             return true;
         }