add isset/unset keys

Author: TomasVotruba

rules-tests/TypeDeclaration/Rector/ClassMethod/KnownMagicClassMethodTypeRector/Fixture/isset_unset.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\KnownMagicClassMethodTypeRector\Fixture;
+
+final class IssetUnset
+{
+    public function __isset($key): bool
+    {
+        return true;
+    }
+
+    public function __unset($key): void
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\KnownMagicClassMethodTypeRector\Fixture;
+
+final class IssetUnset
+{
+    public function __isset(string $key): bool
+    {
+        return true;
+    }
+
+    public function __unset(string $key): void
+    {
+    }
+}
+
+?>

rules/TypeDeclaration/Rector/ClassMethod/KnownMagicClassMethodTypeRector.php

@@ -78,20 +78,25 @@ public function refactor(Node $node): ?Node
             }
 
             if ($this->isNames($classMethod, [MethodName::CALL, MethodName::CALL_STATIC])) {
-                $firstParam = $classMethod->getParams()[0];
-                if (! $firstParam->type instanceof Node) {
-                    $firstParam->type = new Identifier('string');
-                    $hasChanged = true;
-                }
-
                 $secondParam = $classMethod->getParams()[1];
                 if (! $secondParam->type instanceof Node) {
                     $secondParam->type = new Name('array');
                     $hasChanged = true;
                 }
             }
 
-            if ($this->isName($classMethod, MethodName::__GET)) {
+            // first arg string
+            if ($this->isNames(
+                $classMethod,
+                [
+                    MethodName::CALL,
+                    MethodName::CALL_STATIC,
+                    MethodName::__SET,
+                    MethodName::__GET,
+                    MethodName::ISSET,
+                    MethodName::UNSET,
+                ]
+            )) {
                 $firstParam = $classMethod->getParams()[0];
                 if (! $firstParam->type instanceof Node) {
                     $firstParam->type = new Identifier('string');
@@ -100,12 +105,6 @@ public function refactor(Node $node): ?Node
             }
 
             if ($this->isName($classMethod, MethodName::__SET)) {
-                $firstParam = $classMethod->getParams()[0];
-                if (! $firstParam->type instanceof Node) {
-                    $firstParam->type = new Identifier('string');
-                    $hasChanged = true;
-                }
-
                 if ($this->phpVersionProvider->isAtLeastPhpVersion(PhpVersionFeature::MIXED_TYPE)) {
                     $secondParam = $classMethod->getParams()[1];
                     if (! $secondParam->type instanceof Node) {

src/ValueObject/MethodName.php

@@ -77,4 +77,9 @@ final class MethodName
      * @var string
      */
     public const ISSET = '__isset';
+
+    /**
+     * @var string
+     */
+    public const UNSET = '__unset';
 }