[depre] Deprecate DisallowedShortTernaryRuleFixerRector as risky and not practical

Author: TomasVotruba

config/set/strict-booleans.php

@@ -4,8 +4,7 @@
 
 use Rector\Config\RectorConfig;
 use Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector;
-use Rector\Strict\Rector\Ternary\DisallowedShortTernaryRuleFixerRector;
 
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([DisallowedEmptyRuleFixerRector::class, DisallowedShortTernaryRuleFixerRector::class]);
+    $rectorConfig->rules([DisallowedEmptyRuleFixerRector::class]);
 };

rules-tests/Strict/Rector/Ternary/DisallowedShortTernaryRuleFixerRector/DisallowedShortTernaryRuleFixerRectorTest.php

@@ -5,30 +5,22 @@
 namespace Rector\Strict\Rector\Ternary;
 
 use PhpParser\Node;
-use PhpParser\Node\Expr;
-use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\Ternary;
-use PHPStan\Analyser\Scope;
-use Rector\PHPStan\ScopeFetcher;
-use Rector\Strict\NodeFactory\ExactCompareFactory;
-use Rector\Strict\Rector\AbstractFalsyScalarRuleFixerRector;
+use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
+use Rector\Exception\ShouldNotHappenException;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
 /**
  * Fixer Rector for PHPStan rule:
  * https://github.com/phpstan/phpstan-strict-rules/blob/master/src/Rules/DisallowedConstructs/DisallowedShortTernaryRule.php
  *
- * @see \Rector\Tests\Strict\Rector\Ternary\DisallowedShortTernaryRuleFixerRector\DisallowedShortTernaryRuleFixerRectorTest
+ * @deprecated as risky and not practical
  */
-final class DisallowedShortTernaryRuleFixerRector extends AbstractFalsyScalarRuleFixerRector
+final class DisallowedShortTernaryRuleFixerRector extends AbstractRector implements DeprecatedInterface
 {
-    private bool $hasChanged = false;
-
-    public function __construct(
-        private readonly ExactCompareFactory $exactCompareFactory,
-    ) {
-    }
+    public const TREAT_AS_NON_EMPTY = 'treat_as_non_empty';
 
     public function getRuleDefinition(): RuleDefinition
     {
@@ -78,65 +70,6 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Ternary
     {
-        $this->hasChanged = false;
-
-        // skip non-short ternary
-        if ($node->if instanceof Expr) {
-            return null;
-        }
-
-        $scope = ScopeFetcher::fetch($node);
-
-        // special case for reset() function
-        if ($node->cond instanceof FuncCall && $this->isName($node->cond, 'reset')) {
-            $this->refactorResetFuncCall($node, $node->cond, $scope);
-
-            if (! $this->hasChanged) {
-                return null;
-            }
-
-            return $node;
-        }
-
-        $exprType = $scope->getNativeType($node->cond);
-        $compareExpr = $this->exactCompareFactory->createNotIdenticalFalsyCompare(
-            $exprType,
-            $node->cond,
-            $this->treatAsNonEmpty
-        );
-        if (! $compareExpr instanceof Expr) {
-            return null;
-        }
-
-        $node->if = $node->cond;
-        $node->cond = $compareExpr;
-
-        return $node;
-    }
-
-    private function refactorResetFuncCall(Ternary $ternary, FuncCall $resetFuncCall, Scope $scope): void
-    {
-        $ternary->if = $ternary->cond;
-
-        if ($resetFuncCall->isFirstClassCallable()) {
-            return;
-        }
-
-        $firstArgValue = $resetFuncCall->getArgs()[0]
-            ->value;
-        $firstArgType = $scope->getNativeType($firstArgValue);
-
-        $falsyCompareExpr = $this->exactCompareFactory->createNotIdenticalFalsyCompare(
-            $firstArgType,
-            $firstArgValue,
-            $this->treatAsNonEmpty
-        );
-
-        if (! $falsyCompareExpr instanceof Expr) {
-            return;
-        }
-
-        $ternary->cond = $falsyCompareExpr;
-        $this->hasChanged = true;
+        throw new ShouldNotHappenException('This rule is deprecated as risky and not practical');
     }
 }

rules-tests/Strict/Rector/Ternary/DisallowedShortTernaryRuleFixerRector/Fixture/reset_trait.php.inc

@@ -760,6 +760,7 @@ public function withPreparedSets(
         bool $naming = false,
         bool $instanceOf = false,
         bool $earlyReturn = false,
+        // @deprecated
         bool $strictBooleans = false,
         bool $carbon = false,
         bool $rectorPreset = false,
@@ -780,7 +781,6 @@ public function withPreparedSets(
             SetList::NAMING => $naming,
             SetList::INSTANCEOF => $instanceOf,
             SetList::EARLY_RETURN => $earlyReturn,
-            SetList::STRICT_BOOLEANS => $strictBooleans,
             SetList::CARBON => $carbon,
             SetList::RECTOR_PRESET => $rectorPreset,
             PHPUnitSetList::PHPUNIT_CODE_QUALITY => $phpunitCodeQuality,

rules-tests/Strict/Rector/Ternary/DisallowedShortTernaryRuleFixerRector/Fixture/short_ternary_array.php.inc

@@ -31,6 +31,7 @@ final class SetList
     public const DEAD_CODE = __DIR__ . '/../../../config/set/dead-code.php';
 
     /**
+     * @deprecated As too strict and not practical. Use code quality and coding style sets instead.
      * @var string
      */
     public const STRICT_BOOLEANS = __DIR__ . '/../../../config/set/strict-booleans.php';