[DeadCode] Skip with different default param value child vs parent on RemoveParentDelegatingConstructorRector

Author: samsonasik

rules-tests/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector/Fixture/skip_different_default_param_value.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector\Fixture;
+
+class SkipWithDefaultParams extends \DateTime
+{
+    public function __construct(string $datetime = "tomorrow", ?\DateTimeZone $timezone = null)
+    {
+        parent::__construct($datetime, $timezone);
+    }
+}

rules-tests/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector/Fixture/with_equal_default_param_value.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector\Fixture;
+
+class WithEqualDefaultParamValue extends \DateTime
+{
+    public function __construct(string $datetime = "now", ?\DateTimeZone $timezone = null)
+    {
+        parent::__construct($datetime, $timezone);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector\Fixture;
+
+class WithEqualDefaultParamValue extends \DateTime
+{
+}
+
+?>

rules/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Arg;
+use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt;
@@ -15,9 +16,11 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\ExtendedMethodReflection;
 use Rector\Enum\ObjectReference;
+use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\PHPStan\ScopeFetcher;
 use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
 use Rector\Rector\AbstractRector;
+use Rector\Reflection\ReflectionResolver;
 use Rector\StaticTypeMapper\StaticTypeMapper;
 use Rector\ValueObject\MethodName;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -30,6 +33,7 @@ final class RemoveParentDelegatingConstructorRector extends AbstractRector
 {
     public function __construct(
         private readonly StaticTypeMapper $staticTypeMapper,
+        private readonly ValueResolver $valueResolver
     ) {
     }
 
@@ -207,6 +211,7 @@ private function areConstructorAndParentParameterTypesMatching(
         ClassMethod $classMethod,
         ExtendedMethodReflection $extendedMethodReflection
     ): bool {
+        $methodName = $this->getName($classMethod);
         foreach ($classMethod->getParams() as $position => $param) {
             $parameterType = $param->type;
 
@@ -230,6 +235,18 @@ private function areConstructorAndParentParameterTypesMatching(
                 if (! $this->nodeComparator->areNodesEqual($parameterType, $parentParameterType)) {
                     return false;
                 }
+
+                if ($extendedMethodReflection->getDeclaringClass()->getNativeReflection()->hasMethod($methodName)) {
+                    $parentMethod = $extendedMethodReflection->getDeclaringClass()->getNativeReflection()->getMethod($methodName);
+                    $nativeParentParameterReflection = $parentMethod->getParameters()[$index] ?? null;
+
+                    $parentDefault = $nativeParentParameterReflection->getDefaultValue();
+                    $currentDefault = $this->valueResolver->getValue($param->default);
+
+                    if ($parentDefault !== $currentDefault) {
+                        return false;
+                    }
+                }
             }
         }