[DeadCode] Skip with assign to call with target has #[NoDiscard] attribute on RemoveUnusedVariableAssignRector (#7950)

* [DeadCode] Skip with assign to call with target has #[NoDiscard] attribute

* [DeadCode] Skip with assign to call with target has #[NoDiscard] attribute

* [DeadCode] Skip with assign to call with target has #[NoDiscard] attribute

* [DeadCode] Skip with assign to call with target has #[NoDiscard] attribute

* [DeadCode] Skip with assign to call with target has #[NoDiscard] attribute

* rename test

Author: samsonasik

rules-tests/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector/Fixture/skip_assign_no_discard_method_call.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Assign\RemoveUnusedVariableAssignRector\Fixture;
+
+class SkipAssignNoDiscardMethodCall
+{
+    public function run()
+    {
+        $value = $this->some_call();
+    }
+
+    #[\NoDiscard]
+    private function some_call()
+    {
+
+    }
+}

rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php

@@ -12,6 +12,10 @@
 use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\Include_;
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\New_;
+use PhpParser\Node\Expr\NullsafeMethodCall;
+use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Class_;
@@ -25,6 +29,8 @@
 use Rector\NodeAnalyzer\VariableAnalyzer;
 use Rector\NodeManipulator\StmtsManipulator;
 use Rector\Php\ReservedKeywordAnalyzer;
+use Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer;
+use Rector\PhpParser\AstResolver;
 use Rector\PhpParser\Enum\NodeGroup;
 use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\Rector\AbstractRector;
@@ -42,7 +48,9 @@ public function __construct(
         private readonly SideEffectNodeDetector $sideEffectNodeDetector,
         private readonly VariableAnalyzer $variableAnalyzer,
         private readonly BetterNodeFinder $betterNodeFinder,
-        private readonly StmtsManipulator $stmtsManipulator
+        private readonly StmtsManipulator $stmtsManipulator,
+        private readonly AstResolver $astResolver,
+        private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer
     ) {
     }
 
@@ -265,6 +273,18 @@ function (Node $subNode) use (&$refVariableNames) {
                 continue;
             }
 
+            if ($assign->expr instanceof FuncCall
+                || $assign->expr instanceof StaticCall
+                || $assign->expr instanceof MethodCall
+                || $assign->expr instanceof New_
+                || $assign->expr instanceof NullsafeMethodCall) {
+                $targetCall = $this->astResolver->resolveClassMethodOrFunctionFromCall($assign->expr);
+                if (($targetCall instanceof ClassMethod || $targetCall instanceof Function_)
+                    && $this->phpAttributeAnalyzer->hasPhpAttribute($targetCall, 'NoDiscard')) {
+                    continue;
+                }
+            }
+
             $assignedVariableNamesByStmtPosition[$key] = $variableName;
         }
 

rules/Php80/NodeAnalyzer/PhpAttributeAnalyzer.php

@@ -12,6 +12,7 @@
 use PhpParser\Node\Scalar\String_;
 use PhpParser\Node\Stmt\ClassLike;
 use PhpParser\Node\Stmt\ClassMethod;
+use PhpParser\Node\Stmt\Function_;
 use PhpParser\Node\Stmt\Property;
 use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\PhpAttribute\Enum\DocTagNodeState;
@@ -23,7 +24,7 @@ public function __construct(
     ) {
     }
 
-    public function hasPhpAttribute(Property | ClassLike | ClassMethod | Param $node, string $attributeClass): bool
+    public function hasPhpAttribute(Property | ClassLike | ClassMethod | Function_ | Param  $node, string $attributeClass): bool
     {
         foreach ($node->attrGroups as $attrGroup) {
             foreach ($attrGroup->attrs as $attribute) {
@@ -41,7 +42,7 @@ public function hasPhpAttribute(Property | ClassLike | ClassMethod | Param $node
     /**
      * @param string[] $attributeClasses
      */
-    public function hasPhpAttributes(Property | ClassLike | ClassMethod | Param $node, array $attributeClasses): bool
+    public function hasPhpAttributes(Property | ClassLike | ClassMethod | Function_ | Param $node, array $attributeClasses): bool
     {
         foreach ($attributeClasses as $attributeClass) {
             if ($this->hasPhpAttribute($node, $attributeClass)) {

src/PhpParser/AstResolver.php

@@ -112,7 +112,7 @@ function (Node $node) use ($classLikeName, $methodName, &$classMethod): bool {
     }
 
     public function resolveClassMethodOrFunctionFromCall(
-        FuncCall | StaticCall | MethodCall | New_ $call
+        FuncCall | StaticCall | MethodCall | New_ | NullsafeMethodCall $call
     ): ClassMethod | Function_ | null {
         if ($call instanceof FuncCall) {
             return $this->resolveFunctionFromFuncCall($call);