revert adding post rectors to applied rules as not relevant in result

Author: TomasVotruba

src/Bridge/SetRectorsResolver.php

@@ -62,7 +62,7 @@ public function resolveFromFilePathIncludingConfiguration(string $configFilePath
             ];
         }
 
-        // sort keys
+        // sortAndFilterOutPostRectors keys
         return array_values($rectorClassesWithOptionalConfiguration);
     }
 

src/ChangesReporting/ValueObjectFactory/FileDiffFactory.php

@@ -36,11 +36,6 @@ public function createFileDiffWithLineChanges(
         $consoleDiff = $shouldShowDiffs ? $this->colorConsoleDiffFormatter->format($diff) : '';
 
         // always keep the most recent diff
-        return new FileDiff(
-            $relativeFilePath,
-            $diff,
-            $consoleDiff,
-            $rectorsWithLineChanges
-        );
+        return new FileDiff($relativeFilePath, $diff, $consoleDiff, $rectorsWithLineChanges);
     }
 }

src/Testing/PHPUnit/ValueObject/RectorTestResult.php

@@ -36,6 +36,6 @@ public function getAppliedRectorClasses(): array
             $rectorClasses = array_merge($rectorClasses, $fileDiff->getRectorClasses());
         }
 
-        return RectorClassesSorter::sort($rectorClasses);
+        return RectorClassesSorter::sortAndFilterOutPostRectors($rectorClasses);
     }
 }

src/Util/RectorClassesSorter.php

@@ -16,22 +16,16 @@ final class RectorClassesSorter
      * @param array<class-string<RectorInterface|PostRectorInterface>> $rectorClasses
      * @return array<class-string<RectorInterface|PostRectorInterface>>
      */
-    public static function sort(array $rectorClasses): array
+    public static function sortAndFilterOutPostRectors(array $rectorClasses): array
     {
         $rectorClasses = array_unique($rectorClasses);
 
-        $mainRector = array_filter(
+        $mainRectorClasses = array_filter(
             $rectorClasses,
             fn (string $rectorClass): bool => is_a($rectorClass, RectorInterface::class, true)
         );
-        sort($mainRector);
+        sort($mainRectorClasses);
 
-        $postRector = array_filter(
-            $rectorClasses,
-            fn (string $rectorClass): bool => is_a($rectorClass, PostRectorInterface::class, true)
-        );
-        sort($postRector);
-
-        return array_merge($mainRector, $postRector);
+        return $mainRectorClasses;
     }
 }

src/ValueObject/Reporting/FileDiff.php

@@ -93,7 +93,7 @@ public function getRectorClasses(): array
             $rectorClasses[] = $rectorWithLineChange->getRectorClass();
         }
 
-        return RectorClassesSorter::sort($rectorClasses);
+        return RectorClassesSorter::sortAndFilterOutPostRectors($rectorClasses);
     }
 
     public function getFirstLineNumber(): ?int