[deprecation] Add explicit warning to withPhpPolyfill() deprecated method + raise error on ->withPhpSets() miss-use on PHP 7.4- projects (#6790)

* [deprecation] Add explicit warning to withPhpPolyfill() deprecated method

* [dx] Add explicit warning for withPhpSets() use in PHP 7.4- version to avoid magic true false args

* cleanup unreachable code

Author: TomasVotruba

src/Configuration/RectorConfigBuilder.php

@@ -499,10 +499,12 @@ public function withAttributesSets(
      * @deprecated Already included in withPhpSets(), no need to repeat
      * make use of polyfill packages in composer.json
      */
-    public function withPhpPolyfill(): self
+    public function withPhpPolyfill(): never
     {
-        $this->sets[] = SetList::PHP_POLYFILLS;
-        return $this;
+        throw new InvalidConfigurationException(sprintf(
+            'Method "%s()" is deprecated and is now part of ->withPhpSets() to avoid duplications and too granular configuration.',
+            __METHOD__,
+        ));
     }
 
     /**
@@ -537,7 +539,7 @@ public function withPhpSets(
 
         $pickedArguments = array_filter(func_get_args());
         if ($pickedArguments !== []) {
-            Notifier::notifyWithPhpSetsNotSuitableForPHP80();
+            Notifier::errorWithPhpSetsNotSuitableForPHP74AndLower();
         }
 
         if (count($pickedArguments) > 1) {

src/Console/Notifier.php

@@ -4,6 +4,7 @@
 
 namespace Rector\Console;
 
+use Rector\Exception\Configuration\InvalidConfigurationException;
 use Symfony\Component\Console\Input\ArgvInput;
 use Symfony\Component\Console\Output\ConsoleOutput;
 use Symfony\Component\Console\Style\SymfonyStyle;
@@ -27,17 +28,14 @@ public static function notifyNotSuitableMethodForPHP74(string $calledMethod): vo
         sleep(3);
     }
 
-    public static function notifyWithPhpSetsNotSuitableForPHP80(): void
+    public static function errorWithPhpSetsNotSuitableForPHP74AndLower(): void
     {
         if (PHP_VERSION_ID >= 80000) {
             return;
         }
 
-        $message = 'The "withPhpSets()" method uses named arguments. Its suitable for PHP 8.0+. Use more explicit "withPhp53Sets()" ... "withPhp74Sets()" in lower PHP versions instead.';
-
-        $symfonyStyle = new SymfonyStyle(new ArgvInput(), new ConsoleOutput());
-        $symfonyStyle->warning($message);
-
-        sleep(3);
+        throw new InvalidConfigurationException(
+            'The "->withPhpSets()" method uses named arguments. Its suitable for PHP 8.0+. Use more explicit "->withPhp53Sets()" ... "->withPhp74Sets()" in lower PHP versions instead.'
+        );
     }
 }