[DeadCode] Add RemoveUselessTernaryRector (#7961)

* [DeadCode] Add RemoveUselessTernaryRector

* skip negated

* rename fixture

* comment

* early check

* final touch: more fixture

* final touch: handle true false on bool

* final touch: handle true false on bool

Author: samsonasik

rules-tests/DeadCode/Rector/Ternary/RemoveUselessTernaryRector/Fixture/fixture.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class Fixture
+{
+    public function go(bool $value)
+    {
+        return $value ?: false;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class Fixture
+{
+    public function go(bool $value)
+    {
+        return $value;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Ternary/RemoveUselessTernaryRector/Fixture/skip_different_type.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class SkipDifferentType
+{
+    public function go(bool $value)
+    {
+        return $value ?: 0;
+    }
+}

rules-tests/DeadCode/Rector/Ternary/RemoveUselessTernaryRector/Fixture/skip_docblock_type.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class SkipDocblockType
+{
+    /**
+     * @param bool $value
+     */
+    public function go($value)
+    {
+        return $value ?: false;
+    }
+}

rules-tests/DeadCode/Rector/Ternary/RemoveUselessTernaryRector/Fixture/skip_negated_cond.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class SkipNegatedCond
+{
+    public function go(bool $value)
+    {
+        return ! $value ?: false;
+    }
+}

rules-tests/DeadCode/Rector/Ternary/RemoveUselessTernaryRector/Fixture/skip_union.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class SkipUnion
+{
+    public function go(bool|string $value)
+    {
+        return $value ?: false;
+    }
+}

rules-tests/DeadCode/Rector/Ternary/RemoveUselessTernaryRector/Fixture/skip_with_if_not_equal.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class SkipWithIfNotEqual
+{
+    public function go(bool $value)
+    {
+        return $value ? 1 : false;
+    }
+}

rules-tests/DeadCode/Rector/Ternary/RemoveUselessTernaryRector/Fixture/true_false_on_bool.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class TrueFalseOnBool
+{
+    public function go(bool $value)
+    {
+        return $value ? true : false;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class TrueFalseOnBool
+{
+    public function go(bool $value)
+    {
+        return $value;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Ternary/RemoveUselessTernaryRector/Fixture/with_array_empty.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class WithArrayEmpty
+{
+    public function go(array $value)
+    {
+        return $value ?: [];
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class WithArrayEmpty
+{
+    public function go(array $value)
+    {
+        return $value;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Ternary/RemoveUselessTernaryRector/Fixture/with_if_equal.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class WithIfEqual
+{
+    public function go(bool $value)
+    {
+        return $value ? $value : false;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class WithIfEqual
+{
+    public function go(bool $value)
+    {
+        return $value;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Ternary/RemoveUselessTernaryRector/Fixture/with_integer_zero.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class WithIntegerZero
+{
+    public function go(int $value)
+    {
+        return $value ?: 0;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Ternary\RemoveUselessTernaryRector\Fixture;
+
+class WithIntegerZero
+{
+    public function go(int $value)
+    {
+        return $value;
+    }
+}
+
+?>