[DeadCode] Skip used by Array callable on RemoveEmptyClassMethodRector (#6908)

Author: samsonasik

rules-tests/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector/Fixture/skip_used_by_array_callable.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector\Source\MyDIContainer;
+
+final class SkipUsedByArrayCallable
+{
+    public function run()
+    {
+        $container = new MyDIContainer();
+        $container->call([$this, 'doFoo']);
+    }
+
+    public function doFoo() {
+    }
+}

rules-tests/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector/Source/MyDIContainer.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector\Source;
+
+class MyDIContainer
+{
+    public function call(callable $callback, array $parameters = []): mixed
+    {
+    }
+}

rules/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector.php

@@ -5,6 +5,7 @@
 namespace Rector\DeadCode\Rector\ClassMethod;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\Array_;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Name\FullyQualified;
@@ -15,8 +16,10 @@
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\DeadCode\NodeManipulator\ControllerClassMethodManipulator;
 use Rector\NodeAnalyzer\ParamAnalyzer;
+use Rector\NodeCollector\NodeAnalyzer\ArrayCallableMethodMatcher;
 use Rector\NodeManipulator\ClassMethodManipulator;
 use Rector\PhpParser\Node\BetterNodeFinder;
+use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
 use Rector\ValueObject\MethodName;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -32,7 +35,8 @@ public function __construct(
         private readonly ControllerClassMethodManipulator $controllerClassMethodManipulator,
         private readonly ParamAnalyzer $paramAnalyzer,
         private readonly PhpDocInfoFactory $phpDocInfoFactory,
-        private readonly BetterNodeFinder $betterNodeFinder
+        private readonly BetterNodeFinder $betterNodeFinder,
+        private readonly ArrayCallableMethodMatcher $arrayCallableMethodMatcher
     ) {
     }
 
@@ -132,14 +136,15 @@ private function shouldSkipNonFinalNonPrivateClassMethod(Class_ $class, ClassMet
     private function shouldSkipClassMethod(Class_ $class, ClassMethod $classMethod): bool
     {
         $desiredClassMethodName = $this->getName($classMethod);
+        $className = (string) $this->getName($class);
 
         // is method called somewhere else in the class?
         foreach ($class->getMethods() as $anotherClassMethod) {
             if ($anotherClassMethod === $classMethod) {
                 continue;
             }
 
-            if ($this->containsMethodCall($anotherClassMethod, $desiredClassMethodName)) {
+            if ($this->containsMethodCallOrArrayCallable($anotherClassMethod, $desiredClassMethodName, $className)) {
                 return true;
             }
         }
@@ -182,11 +187,22 @@ private function hasDeprecatedAnnotation(ClassMethod $classMethod): bool
         return $phpDocInfo->hasByType(DeprecatedTagValueNode::class);
     }
 
-    private function containsMethodCall(ClassMethod $anotherClassMethod, string $desiredClassMethodName): bool
+    private function containsMethodCallOrArrayCallable(ClassMethod $anotherClassMethod, string $desiredClassMethodName, string $className): bool
     {
+        $scope = ScopeFetcher::fetch($anotherClassMethod);
         return (bool) $this->betterNodeFinder->findFirst($anotherClassMethod, function (Node $node) use (
-            $desiredClassMethodName
+            $desiredClassMethodName,
+            $className,
+            $scope
         ): bool {
+            if ($node instanceof Array_) {
+                return (bool) $this->arrayCallableMethodMatcher->match(
+                    $node,
+                    $scope,
+                    $className
+                );
+            }
+
             if (! $node instanceof MethodCall) {
                 return false;
             }