[PHP 8.3] Make use of typed constants (#7839)

* [PHP 8.3] Remove docblock if useless in AddTypeToConstRector to avoid duplicated leftovers"

* fixup! [PHP 8.3] Remove docblock if useless in AddTypeToConstRector to avoid duplicated leftovers"

* [PHP 8.3] Make use of typed constants

Author: TomasVotruba

build/build-preload.php

@@ -43,10 +43,7 @@
 
 final class PreloadBuilder
 {
-    /**
-     * @var string
-     */
-    private const PRELOAD_FILE_TEMPLATE = <<<'CODE_SAMPLE'
+    private const string PRELOAD_FILE_TEMPLATE = <<<'CODE_SAMPLE'
 <?php
 
 declare(strict_types=1);
@@ -75,18 +72,15 @@ function isPHPStanTestPreloaded(): bool
 }
 CODE_SAMPLE;
 
-    /**
-     * @var int
-     */
-    private const PRIORITY_LESS_FILE_POSITION = -1;
+    private const int PRIORITY_LESS_FILE_POSITION = -1;
 
     /**
      * These files are parent to another files, so they have to be included first
      * See https://github.com/rectorphp/rector/issues/6709 for more
      *
      * @var string[]
      */
-    private const HIGH_PRIORITY_FILES = [
+    private const array HIGH_PRIORITY_FILES = [
         // nikic/php-parser
         'Node.php',
         'NodeAbstract.php',
@@ -131,7 +125,7 @@ function isPHPStanTestPreloaded(): bool
      *
      * @var string[]
      */
-    private const IN_USE_CLASS_FILES = [
+    private const array IN_USE_CLASS_FILES = [
         'Node/Expr/ArrayItem.php',
         'Node/Expr/ClosureUse.php',
         'Node/Scalar/EncapsedStringPart.php',

rector.php

@@ -6,6 +6,7 @@
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\ConstFetch\RemovePhpVersionIdCheckRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
+use Rector\Php83\Rector\ClassConst\AddTypeToConstRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\AddSeeTestAnnotationRector;
 use Rector\Utils\Rector\RemoveRefactorDuplicatedNodeInstanceCheckRector;
 
@@ -39,7 +40,10 @@
     ])
     ->withRootFiles()
     ->withImportNames(removeUnusedImports: true)
-    ->withRules([RemoveRefactorDuplicatedNodeInstanceCheckRector::class, AddSeeTestAnnotationRector::class])
+    ->withRules([
+        RemoveRefactorDuplicatedNodeInstanceCheckRector::class, AddSeeTestAnnotationRector::class,
+        AddTypeToConstRector::class,
+    ])
     ->withSkip([
         StringClassNameToClassConstantRector::class,
         // tests

rules-tests/Php83/Rector/ClassConst/AddTypeToConstRector/Fixture/remove_docblock_as_useless.php.inc

@@ -0,0 +1,24 @@
+<?php
+
+namespace Rector\Tests\Php83\Rector\ClassConst\AddTypeToConstRector\Fixture;
+
+final class RemoveDocBlockAsUseless
+{
+    /**
+     * @var int
+     */
+    private const A = 1000;
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php83\Rector\ClassConst\AddTypeToConstRector\Fixture;
+
+final class RemoveDocBlockAsUseless
+{
+    private const int A = 1000;
+}
+
+?>

rules/Arguments/NodeAnalyzer/ArgumentAddingScope.php

@@ -16,21 +16,18 @@
 {
     /**
      * @api
-     * @var string
      */
-    public const SCOPE_PARENT_CALL = 'parent_call';
+    public const string SCOPE_PARENT_CALL = 'parent_call';
 
     /**
      * @api
-     * @var string
      */
-    public const SCOPE_METHOD_CALL = 'method_call';
+    public const string SCOPE_METHOD_CALL = 'method_call';
 
     /**
      * @api
-     * @var string
      */
-    public const SCOPE_CLASS_METHOD = 'class_method';
+    public const string SCOPE_CLASS_METHOD = 'class_method';
 
     public function __construct(
         private NodeNameResolver $nodeNameResolver

rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php

@@ -10,10 +10,7 @@
 
 final readonly class ReplaceArgumentDefaultValue implements ReplaceArgumentDefaultValueInterface
 {
-    /**
-     * @var string
-     */
-    public const ANY_VALUE_BEFORE = '*ANY_VALUE_BEFORE*';
+    public const string ANY_VALUE_BEFORE = '*ANY_VALUE_BEFORE*';
 
     /**
      * @param int<0, max> $position

rules/Assert/Enum/AssertClassName.php

@@ -6,13 +6,7 @@
 
 final class AssertClassName
 {
-    /**
-     * @var string
-     */
-    public const WEBMOZART = 'Webmozart\Assert\Assert';
+    public const string WEBMOZART = 'Webmozart\Assert\Assert';
 
-    /**
-     * @var string
-     */
-    public const BEBERLEI = 'Assert\Assertion';
+    public const string BEBERLEI = 'Assert\Assertion';
 }

rules/Carbon/NodeFactory/CarbonCallFactory.php

@@ -16,16 +16,14 @@
 final class CarbonCallFactory
 {
     /**
-     * @var string
      * @see https://regex101.com/r/LLMrFw/1
      */
-    private const PLUS_MINUS_COUNT_REGEX = '#(?<operator>\+|-)(\\s+)?(?<count>\\d+)(\s+)?(?<unit>seconds|second|sec|minutes|minute|min|hours|hour|days|day|weeks|week|months|month|years|year)#';
+    private const string PLUS_MINUS_COUNT_REGEX = '#(?<operator>\+|-)(\\s+)?(?<count>\\d+)(\s+)?(?<unit>seconds|second|sec|minutes|minute|min|hours|hour|days|day|weeks|week|months|month|years|year)#';
 
     /**
-     * @var string
      * @see https://regex101.com/r/IhxHTO/1
      */
-    private const STATIC_DATE_REGEX = '#now|yesterday|today|tomorrow#';
+    private const string STATIC_DATE_REGEX = '#now|yesterday|today|tomorrow#';
 
     public function createFromDateTimeString(
         FullyQualified $carbonFullyQualified,

rules/Carbon/Rector/FuncCall/DateFuncCallToCarbonRector.php

@@ -24,7 +24,7 @@
  */
 final class DateFuncCallToCarbonRector extends AbstractRector
 {
-    private const TIME_UNITS = [
+    private const array TIME_UNITS = [
         ['weeks', 604800],
         ['days', 86400],
         ['hours', 3600],

rules/CodeQuality/NodeAnalyzer/LocalPropertyAnalyzer.php

@@ -28,10 +28,7 @@
 
 final readonly class LocalPropertyAnalyzer
 {
-    /**
-     * @var string
-     */
-    private const LARAVEL_COLLECTION_CLASS = 'Illuminate\Support\Collection';
+    private const string LARAVEL_COLLECTION_CLASS = 'Illuminate\Support\Collection';
 
     public function __construct(
         private SimpleCallableNodeTraverser $simpleCallableNodeTraverser,

rules/CodeQuality/Rector/Catch_/ThrowWithPreviousExceptionRector.php

@@ -29,10 +29,7 @@
  */
 final class ThrowWithPreviousExceptionRector extends AbstractRector
 {
-    /**
-     * @var int
-     */
-    private const DEFAULT_EXCEPTION_ARGUMENT_POSITION = 2;
+    private const int DEFAULT_EXCEPTION_ARGUMENT_POSITION = 2;
 
     public function __construct(
         private readonly ReflectionProvider $reflectionProvider