[Php74] Skip ObjectProphecy type on TypedPropertyRector (#1358)

Author: samsonasik

rules-tests/Php74/Rector/Property/TypedPropertyRector/FixtureClassLikeTypeOnly/skip_union_object_prophecy.php.inc

@@ -0,0 +1,28 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use PHPUnit\Framework\TestCase;
+use Prophecy\Prophecy\ObjectProphecy;
+use Prophecy\PhpUnit\ProphecyTrait;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\ReturnString;
+
+class ReturnStringTest extends TestCase
+{
+    use ProphecyTrait;
+
+    /**
+     * @var ReturnString|ObjectProphecy
+     */
+    private $obj;
+
+    protected function setUp(): void
+    {
+        $this->obj = $this->prophesize(ReturnString::class);
+    }
+
+    public function testReturnName()
+    {
+        $this->obj->getName()->willReturn('name')->shouldBeCalled();
+    }
+}

rules-tests/Php74/Rector/Property/TypedPropertyRector/FixtureClassLikeTypeOnly/skip_union_object_prophecy2.php.inc

@@ -0,0 +1,28 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use PHPUnit\Framework\TestCase;
+use Prophecy\Prophecy\ObjectProphecy;
+use Prophecy\PhpUnit\ProphecyTrait;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\ReturnString;
+
+class ReturnString2Test extends TestCase
+{
+    use ProphecyTrait;
+
+    /**
+     * @var ReturnString|ObjectProphecy
+     */
+    private $obj = null;
+
+    protected function setUp(): void
+    {
+        $this->obj = $this->prophesize(ReturnString::class);
+    }
+
+    public function testReturnName()
+    {
+        $this->obj->getName()->willReturn('name')->shouldBeCalled();
+    }
+}

rules/Php74/Rector/Property/TypedPropertyRector.php

@@ -27,11 +27,11 @@
 use Rector\DeadCode\PhpDoc\TagRemover\VarTagRemover;
 use Rector\FamilyTree\Reflection\FamilyRelationsAnalyzer;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\Php74\TypeAnalyzer\ObjectTypeAnalyzer;
 use Rector\Php74\TypeAnalyzer\PropertyUnionTypeResolver;
 use Rector\PHPStanStaticTypeMapper\DoctrineTypeAnalyzer;
 use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
 use Rector\StaticTypeMapper\ValueObject\Type\AliasedObjectType;
-use Rector\StaticTypeMapper\ValueObject\Type\NonExistingObjectType;
 use Rector\TypeDeclaration\TypeInferer\PropertyTypeInferer;
 use Rector\VendorLocker\VendorLockResolver;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
@@ -81,6 +81,7 @@ public function __construct(
         private PropertyAnalyzer $propertyAnalyzer,
         private PropertyUnionTypeResolver $propertyUnionTypeResolver,
         private AstResolver $astResolver,
+        private ObjectTypeAnalyzer $objectTypeAnalyzer
     ) {
     }
 
@@ -153,8 +154,7 @@ public function refactor(Node $node): ?Node
             }
         }
 
-        // we are not sure what object type this is
-        if ($varType instanceof NonExistingObjectType) {
+        if ($this->objectTypeAnalyzer->isSpecial($varType)) {
             return null;
         }
 

rules/Php74/TypeAnalyzer/ObjectTypeAnalyzer.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php74\TypeAnalyzer;
+
+use PHPStan\Type\Type;
+use PHPStan\Type\UnionType;
+use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType;
+use Rector\StaticTypeMapper\ValueObject\Type\NonExistingObjectType;
+
+final class ObjectTypeAnalyzer
+{
+    public function isSpecial(Type $varType): bool
+    {
+        // we are not sure what object type this is
+        if ($varType instanceof NonExistingObjectType) {
+            return true;
+        }
+
+        $types = ! $varType instanceof UnionType
+            ? [$varType]
+            : $varType->getTypes();
+
+        foreach ($types as $type) {
+            if ($type instanceof FullyQualifiedObjectType && $type->getClassName() === 'Prophecy\Prophecy\ObjectProphecy') {
+                return true;
+            }
+        }
+
+        return false;
+    }
+}