[CodeQuality] Skip possibly undefined variable on SimplifyEmptyCheckOnEmptyArrayRector (#8006)

* [CodeQuality] Skip possibly undefined variable on SimplifyEmptyCheckOnEmptyArrayRector

* fix

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: samsonasik

rules-tests/CodeQuality/Rector/Empty_/SimplifyEmptyCheckOnEmptyArrayRector/Fixture/skip_possibly_undefined_variable.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Empty_\SimplifyEmptyCheckOnEmptyArrayRector\Fixture;
+
+class SkipPossiblyUndefinedVariable
+{
+    public function run(bool $cond): array
+    {
+        if ($cond) {
+            $map = ['a' => 1];
+        }
+
+        // empty() tolerates an undefined $map; `$map === []` does not.
+        if (empty($map)) {
+            return [];
+        }
+
+        return $map;
+    }
+}

src/NodeAnalyzer/ExprAnalyzer.php

@@ -54,10 +54,16 @@
 use PHPStan\Type\ObjectWithoutClassType;
 use PHPStan\Type\UnionType;
 use Rector\Enum\ObjectReference;
+use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 
-final class ExprAnalyzer
+final readonly class ExprAnalyzer
 {
+    public function __construct(
+        private NodeNameResolver $nodeNameResolver
+    ) {
+    }
+
     public function isBoolExpr(Expr $expr): bool
     {
         return $expr instanceof BooleanNot
@@ -158,6 +164,10 @@ public function isNonTypedFromParam(Expr $expr): bool
             return true;
         }
 
+        if (! $scope->hasVariableType((string) $this->nodeNameResolver->getName($expr))->yes()) {
+            return true;
+        }
+
         if ($nativeType instanceof UnionType) {
             return ! $nativeType->equals($type);
         }