[parallel] bump default threads from 16 to 32 to keep up with modern technology (#6877)

* [config] remove def value

* typo

* skip if no paths found

* [parallel] bump default threads from 16 to 32 to keep up with modern technology, alligned with phpstan setup

* typo

* [solid] make AbstractRector::leave() final, to avoid breaking removing mechanism in child classes

Author: TomasVotruba

rector.php

@@ -35,7 +35,7 @@
         __DIR__ . '/build/build-preload.php',
     ])
     ->withRootFiles()
-    ->withImportNames(removeUnusedImports: true)
+    ->withImportNames()
     ->withSkip([
         StringClassNameToClassConstantRector::class,
         // tests

rules/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector.php

@@ -66,7 +66,7 @@ public function beforeTraverse(array $nodes): ?array
             return null;
         }
 
-        if ($this->startWithShebang($this->file)) {
+        if ($this->startsWithShebang($this->file)) {
             return null;
         }
 
@@ -126,7 +126,7 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
-    private function startWithShebang(File $file): bool
+    private function startsWithShebang(File $file): bool
     {
         return str_starts_with($file->getFileContent(), '#!');
     }

src/Application/ApplicationFileProcessor.php

@@ -58,14 +58,15 @@ public function __construct(
     public function run(Configuration $configuration, InputInterface $input): ProcessResult
     {
         $filePaths = $this->filesFinder->findFilesInPaths($configuration->getPaths(), $configuration);
-        $this->missConfigurationReporter->reportVendorInPaths($filePaths);
-        $this->missConfigurationReporter->reportStartWithShortOpenTag();
 
         // no files found
         if ($filePaths === []) {
             return new ProcessResult([], []);
         }
 
+        $this->missConfigurationReporter->reportVendorInPaths($filePaths);
+        $this->missConfigurationReporter->reportStartWithShortOpenTag();
+
         $this->configureCustomErrorHandler();
 
         /**

src/Config/RectorConfig.php

@@ -14,6 +14,7 @@
 use Rector\Contract\Rector\ConfigurableRectorInterface;
 use Rector\Contract\Rector\RectorInterface;
 use Rector\DependencyInjection\Laravel\ContainerMemento;
+use Rector\Enum\Config\Defaults;
 use Rector\Exception\ShouldNotHappenException;
 use Rector\Skipper\SkipCriteriaResolver\SkippedClassResolver;
 use Rector\Validation\RectorConfigValidator;
@@ -93,8 +94,11 @@ public function disableParallel(): void
         SimpleParameterProvider::setParameter(Option::PARALLEL, false);
     }
 
-    public function parallel(int $processTimeout = 120, int $maxNumberOfProcess = 16, int $jobSize = 16): void
-    {
+    public function parallel(
+        int $processTimeout = 120,
+        int $maxNumberOfProcess = Defaults::PARALLEL_MAX_NUMBER_OF_PROCESS,
+        int $jobSize = 16
+    ): void {
         SimpleParameterProvider::setParameter(Option::PARALLEL, true);
         SimpleParameterProvider::setParameter(Option::PARALLEL_JOB_TIMEOUT_IN_SECONDS, $processTimeout);
         SimpleParameterProvider::setParameter(Option::PARALLEL_MAX_NUMBER_OF_PROCESSES, $maxNumberOfProcess);

src/Configuration/RectorConfigBuilder.php

@@ -20,6 +20,7 @@
 use Rector\Contract\Rector\ConfigurableRectorInterface;
 use Rector\Contract\Rector\RectorInterface;
 use Rector\Doctrine\Set\DoctrineSetList;
+use Rector\Enum\Config\Defaults;
 use Rector\Exception\Configuration\InvalidConfigurationException;
 use Rector\Php\PhpVersionResolver\ComposerJsonPhpVersionResolver;
 use Rector\PHPUnit\Set\PHPUnitSetList;
@@ -90,7 +91,7 @@ final class RectorConfigBuilder
 
     private int $parallelTimeoutSeconds = 120;
 
-    private int $parallelMaxNumberOfProcess = 16;
+    private int $parallelMaxNumberOfProcess = Defaults::PARALLEL_MAX_NUMBER_OF_PROCESS;
 
     private int $parallelJobSize = 16;
 

src/Console/Command/ProcessCommand.php

@@ -117,7 +117,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         // 2. add files and directories to static locator
         $this->dynamicSourceLocatorDecorator->addPaths($paths);
-        if ($this->dynamicSourceLocatorDecorator->isPathsEmpty()) {
+        if ($this->dynamicSourceLocatorDecorator->arePathsEmpty()) {
             // read from rector.php, no paths definition needs withPaths() config
             if ($paths === []) {
                 $this->symfonyStyle->error(

src/Enum/Config/Defaults.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Enum\Config;
+
+final class Defaults
+{
+    /**
+     * @var int
+     */
+    public const PARALLEL_MAX_NUMBER_OF_PROCESS = 32;
+}

src/FamilyTree/NodeAnalyzer/ClassChildAnalyzer.php

@@ -82,7 +82,7 @@ private function resolveToStringNativeTypeFromAstResolver(PhpMethodReflection $p
 
         if ($class instanceof ClassLike) {
             $classMethod = $class->getMethod($phpMethodReflection->getName());
-            if ($classMethod instanceof ClassMethod && !$classMethod->returnType instanceof Node) {
+            if ($classMethod instanceof ClassMethod && ! $classMethod->returnType instanceof Node) {
                 return new MixedType();
             }
         }

src/NodeTypeResolver/Reflection/BetterReflection/SourceLocatorProvider/DynamicSourceLocatorProvider.php

@@ -78,7 +78,7 @@ public function provide(): SourceLocator
         return $this->aggregateSourceLocator = new AggregateSourceLocator($sourceLocators);
     }
 
-    public function isPathsEmpty(): bool
+    public function arePathsEmpty(): bool
     {
         return $this->filePaths === [] && $this->directories === [];
     }

src/Rector/AbstractRector.php

@@ -190,7 +190,7 @@ final public function enterNode(Node $node): int|Node|null
      * Replacing nodes in leaveNode() method avoids infinite recursion
      * see"infinite recursion" in https://github.com/nikic/PHP-Parser/blob/master/doc/component/Walking_the_AST.markdown
      */
-    public function leaveNode(Node $node): array|int|Node|null
+    final public function leaveNode(Node $node): array|int|Node|null
     {
         if ($node->hasAttribute(AttributeKey::ORIGINAL_NODE)) {
             return null;