[CodeQuality] Skip not inline comparison identical on RepeatedOrEqualToInArrayRector

Author: samsonasik

rules-tests/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector/Fixture/skip_not_inline_identical.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\BooleanOr\RepeatedOrEqualToInArrayRector\Fixture;
+
+final class SkipNotInlineIdentical
+{
+    public function demo($someVariable): bool
+    {
+        if ($someVariable === 'a' || $someVariable === 'b' || execute(fn(): bool => $someVariable === 'c')) {
+            return true;
+        }
+
+        return false;
+    }
+}

rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php

@@ -14,7 +14,6 @@
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name;
 use Rector\CodeQuality\ValueObject\ComparedExprAndValueExpr;
-use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -24,11 +23,6 @@
  */
 final class RepeatedOrEqualToInArrayRector extends AbstractRector
 {
-    public function __construct(
-        private readonly BetterNodeFinder $betterNodeFinder,
-    ) {
-    }
-
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
@@ -103,8 +97,8 @@ public function refactor(Node $node): ?FuncCall
 
         $args = $this->nodeFactory->createArgs([$firstComparedExprAndValue->getComparedExpr(), $array]);
 
-        $identicals = $this->betterNodeFinder->findInstanceOf($node, Identical::class);
-        $equals = $this->betterNodeFinder->findInstanceOf($node, Equal::class);
+        $identicals = $this->findIdenticalsOrEquals($node, Identical::class);
+        $equals = $this->findIdenticalsOrEquals($node, Equal::class);
 
         if ($identicals !== [] && $equals === []) {
             $args[] = new Arg(new ConstFetch(new Name('true')));
@@ -113,6 +107,24 @@ public function refactor(Node $node): ?FuncCall
         return new FuncCall(new Name('in_array'), $args);
     }
 
+    private function findIdenticalsOrEquals(BooleanOr $booleanOr, string $type = Identical::class): array
+    {
+        $identicalsOrEquals = [];
+        if ($booleanOr->left instanceof $type) {
+            $identicalsOrEquals[] = $booleanOr->left;
+        }
+
+        if ($booleanOr->right instanceof BooleanOr) {
+            $identicalsOrEquals[] = $this->findIdenticalsOrEquals($booleanOr->right, $type);
+        }
+
+        if ($booleanOr->right instanceof $type) {
+            $identicalsOrEquals[] = $booleanOr->right;
+        }
+
+        return $identicalsOrEquals;
+    }
+
     private function isEqualOrIdentical(Expr $expr): bool
     {
         if ($expr instanceof Identical) {