[CodeQuality] Handle property fetch and common nodes crash on InlineArrayReturnAssignRector

Author: samsonasik

rules-tests/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector/Fixture/with_property_fetch.php.inc

@@ -0,0 +1,48 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector\Fixture;
+
+final class WithPropertyFetch
+{
+    private string $name = 'test';
+
+    public function foo($obj): array
+    {
+        $event['name'] = $this->name;
+        $event['payload'] = $this->bar();
+        $event['data'] = $obj?->data;
+        $event['item'] = $obj?->getItem();
+        $event['list'] = clone $obj;
+        $event['verify'] = $obj instanceof \stdClass;
+
+        return $event;
+    }
+
+    private function bar(): array
+    {
+        return [];
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector\Fixture;
+
+final class WithPropertyFetch
+{
+    private string $name = 'test';
+
+    public function foo($obj): array
+    {
+        return ['name' => $this->name, 'payload' => $this->bar(), 'data' => $obj?->data, 'item' => $obj?->getItem(), 'list' => clone $obj, 'verify' => $obj instanceof \stdClass];
+    }
+
+    private function bar(): array
+    {
+        return [];
+    }
+}
+
+?>

src/PhpParser/Node/NodeFactory.php

@@ -23,10 +23,14 @@
 use PhpParser\Node\Expr\BinaryOp\NotIdentical;
 use PhpParser\Node\Expr\Cast;
 use PhpParser\Node\Expr\ClassConstFetch;
+use PhpParser\Node\Expr\Clone_;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Expr\Instanceof_;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\New_;
+use PhpParser\Node\Expr\NullsafeMethodCall;
+use PhpParser\Node\Expr\NullsafePropertyFetch;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\StaticPropertyFetch;
@@ -377,6 +381,12 @@ private function createArrayItem(mixed $item, string | int | null $key = null):
             || $item instanceof Scalar
             || $item instanceof Cast
             || $item instanceof ConstFetch
+            || $item instanceof PropertyFetch
+            || $item instanceof StaticPropertyFetch
+            || $item instanceof NullsafePropertyFetch
+            || $item instanceof NullsafeMethodCall
+            || $item instanceof Clone_
+            || $item instanceof Instanceof_
         ) {
             $arrayItem = new ArrayItem($item);
         } elseif ($item instanceof Identifier) {
@@ -411,7 +421,12 @@ private function createArrayItem(mixed $item, string | int | null $key = null):
             return $arrayItem;
         }
 
-        $nodeClass = is_object($item) ? $item::class : $item;
+        // fallback to other nodes
+        if (is_object($item)) {
+            return new ArrayItem($item);
+        }
+
+        $nodeClass = $item;
         throw new NotImplementedYetException(sprintf(
             'Not implemented yet. Go to "%s()" and add check for "%s" node.',
             __METHOD__,