[DeadCode] Handle called by static call on RemoveUnusedPrivateMethodParameterRector (#6912)

* [DeadCode] Handle called by static call on RemoveUnusedPrivateMethodParameterRector

* rectiry

* rectiry

Author: samsonasik

rules-tests/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodParameterRector/Fixture/remove_on_caller_via_self.php.inc

@@ -0,0 +1,42 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector\Fixture;
+
+class RemoveOnCallerViaSelf
+{
+	private static function just_a_test(
+        string $foo,
+        array $bar,
+        $used_parameter
+    ): void {
+		\external::whatever($foo, $used_parameter);
+	}
+
+	public static function trigger(): void
+	{
+		self::just_a_test('hello', [], 'test');
+	}
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector\Fixture;
+
+class RemoveOnCallerViaSelf
+{
+	private static function just_a_test(
+        string $foo,
+        $used_parameter
+    ): void {
+		\external::whatever($foo, $used_parameter);
+	}
+
+	public static function trigger(): void
+	{
+		self::just_a_test('hello', 'test');
+	}
+}
+
+?>

rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodParameterRector.php

@@ -4,9 +4,10 @@
 
 namespace Rector\DeadCode\Rector\ClassMethod;
 
+use PHPStan\Type\ObjectType;
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Expr\Variable;
+use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
@@ -129,9 +130,10 @@ private function removeCallerArgs(Class_ $class, ClassMethod $classMethod, array
         $methodName = $this->getName($classMethod);
         $keysArg = array_keys($unusedParameters);
 
+        $classObjectType = new ObjectType((string) $this->getName($class));
         foreach ($classMethods as $classMethod) {
-            /** @var MethodCall[] $callers */
-            $callers = $this->resolveCallers($classMethod, $methodName);
+            /** @var MethodCall[]|StaticCall[] $callers */
+            $callers = $this->resolveCallers($classMethod, $methodName, $classObjectType);
             if ($callers === []) {
                 continue;
             }
@@ -145,42 +147,42 @@ private function removeCallerArgs(Class_ $class, ClassMethod $classMethod, array
     /**
      * @param int[] $keysArg
      */
-    private function cleanupArgs(MethodCall $methodCall, array $keysArg): void
+    private function cleanupArgs(MethodCall|StaticCall $call, array $keysArg): void
     {
-        if ($methodCall->isFirstClassCallable()) {
+        if ($call->isFirstClassCallable()) {
             return;
         }
 
-        $args = $methodCall->getArgs();
+        $args = $call->getArgs();
         foreach (array_keys($args) as $key) {
             if (in_array($key, $keysArg, true)) {
                 unset($args[$key]);
             }
         }
 
         // reset arg keys
-        $methodCall->args = array_values($args);
+        $call->args = array_values($args);
     }
 
     /**
-     * @return MethodCall[]
+     * @return MethodCall[]|StaticCall[]
      */
-    private function resolveCallers(ClassMethod $classMethod, string $methodName): array
+    private function resolveCallers(ClassMethod $classMethod, string $methodName, ObjectType $classObjectType): array
     {
-        return $this->betterNodeFinder->find($classMethod, function (Node $subNode) use ($methodName): bool {
-            if (! $subNode instanceof MethodCall) {
+        return $this->betterNodeFinder->find($classMethod, function (Node $subNode) use ($methodName, $classObjectType): bool {
+            if (! $subNode instanceof MethodCall && ! $subNode instanceof StaticCall) {
                 return false;
             }
 
             if ($subNode->isFirstClassCallable()) {
                 return false;
             }
 
-            if (! $subNode->var instanceof Variable) {
-                return false;
-            }
+            $nodeToCheck = $subNode instanceof MethodCall
+                ? $subNode->var
+                : $subNode->class;
 
-            if (! $this->isName($subNode->var, 'this')) {
+            if (! $this->isObjectType($nodeToCheck, $classObjectType)) {
                 return false;
             }