[dx] warn early about deprecated skipped rules, as not neccessary to skip anymore (#7742)

* [dx] warn early about deprecated skipped rules, as not neccessary to skip anymore

* [comp] Restore FirstClassCallableRector and make it explicitly deprecated, to ease transition

Author: TomasVotruba

phpstan.neon

@@ -433,3 +433,12 @@ parameters:
                 - rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php
                 - rules/Php81/Enum/AttributeName.php
 
+        # deprecated rule
+        - '#Rule Rector\\Php81\\Rector\\Array_\\FirstClassCallableRector must implements Rector\\VersionBonding\\Contract\\MinPhpVersionInterface#'
+        - '#Register "Rector\\Php81\\Rector\\Array_\\FirstClassCallableRector" service to "php81\.php" config set#'
+        - '#Access to constant on deprecated class Rector\\Php81\\Rector\\Array_\\FirstClassCallableRector#'
+        -
+            message: '#Only abstract classes can be extended#'
+            path: rules/Php81/Rector/Array_/FirstClassCallableRector.php
+
+

rules/Php81/Rector/Array_/ArrayToFirstClassCallableRector.php

@@ -31,7 +31,7 @@
  * @see RFC https://wiki.php.net/rfc/first_class_callable_syntax
  * @see \Rector\Tests\Php81\Rector\Array_\ArrayToFirstClassCallableRector\ArrayToFirstClassCallableRectorTest
  */
-final class ArrayToFirstClassCallableRector extends AbstractRector implements MinPhpVersionInterface
+class ArrayToFirstClassCallableRector extends AbstractRector implements MinPhpVersionInterface
 {
     public function __construct(
         private readonly ArrayCallableMethodMatcher $arrayCallableMethodMatcher,

rules/Php81/Rector/Array_/FirstClassCallableRector.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Php81\Rector\Array_;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\StaticCall;
+use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
+use Rector\Exception\ShouldNotHappenException;
+
+/**
+ * @deprecated Renamed to \Rector\Php81\Rector\Array_\ArrayToFirstClassCallableRector
+ */
+final class FirstClassCallableRector extends ArrayToFirstClassCallableRector implements DeprecatedInterface
+{
+    public function refactor(Node $node): StaticCall|MethodCall|null
+    {
+        throw new ShouldNotHappenException(sprintf(
+            '%s is deprecated and renamed to "%s". Use it instead.',
+            self::class,
+            ArrayToFirstClassCallableRector::class
+        ));
+    }
+}

src/Console/Command/ListRulesCommand.php

@@ -51,7 +51,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $rectorClasses = $this->resolveRectorClasses();
 
-        $skippedClasses = $this->getSkippedCheckers();
+        $skippedClasses = $this->getSkippedRectorClasses();
 
         $outputFormat = $input->getOption(Option::OUTPUT_FORMAT);
         if ($outputFormat === 'json') {
@@ -95,20 +95,21 @@ private function resolveRectorClasses(): array
     }
 
     /**
-     * @return string[]
+     * @return array<class-string>
      */
-    private function getSkippedCheckers(): array
+    private function getSkippedRectorClasses(): array
     {
-        $skippedCheckers = [];
-        foreach ($this->skippedClassResolver->resolve() as $checkerClass => $fileList) {
+        $skippedRectorClasses = [];
+
+        foreach ($this->skippedClassResolver->resolve() as $rectorClass => $fileList) {
             // ignore specific skips
             if ($fileList !== null) {
                 continue;
             }
 
-            $skippedCheckers[] = $checkerClass;
+            $skippedRectorClasses[] = $rectorClass;
         }
 
-        return $skippedCheckers;
+        return $skippedRectorClasses;
     }
 }

src/Console/Command/ProcessCommand.php

@@ -19,6 +19,7 @@
 use Rector\Exception\ShouldNotHappenException;
 use Rector\Reporting\DeprecatedRulesReporter;
 use Rector\Reporting\MissConfigurationReporter;
+use Rector\Skipper\SkipCriteriaResolver\SkippedClassResolver;
 use Rector\StaticReflection\DynamicSourceLocatorDecorator;
 use Rector\Util\MemoryLimiter;
 use Rector\ValueObject\Configuration;
@@ -45,6 +46,7 @@ public function __construct(
         private readonly DeprecatedRulesReporter $deprecatedRulesReporter,
         private readonly MissConfigurationReporter $missConfigurationReporter,
         private readonly ConfigurationRuleFilter $configurationRuleFilter,
+        private readonly SkippedClassResolver $skippedClassResolver,
     ) {
         parent::__construct();
     }
@@ -105,6 +107,15 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $this->reportLevelOverflow($levelOverflow);
         }
 
+        // 0. warn about skipped rules that are deprecated
+        if ($this->skippedClassResolver->resolveDeprecatedSkippedClasses() !== []) {
+            $this->symfonyStyle->warning(sprintf(
+                'These rules are skipped, but are deprecated. Most likely you do not need to skip them anymore as not part of any set and remove them: %s* %s',
+                "\n\n",
+                implode(' * ', $this->skippedClassResolver->resolveDeprecatedSkippedClasses()) . "\n"
+            ));
+        }
+
         // 1. warn about rules registered in both withRules() and sets to avoid bloated rector.php configs
         $setAndRulesDuplicatedRegistrations = $configuration->getBothSetAndRulesDuplicatedRegistrations();
         if ($setAndRulesDuplicatedRegistrations !== []) {

src/Skipper/SkipCriteriaResolver/SkippedClassResolver.php

@@ -4,34 +4,51 @@
 
 namespace Rector\Skipper\SkipCriteriaResolver;
 
+use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
 use Rector\Configuration\Option;
 use Rector\Configuration\Parameter\SimpleParameterProvider;
 use Rector\Testing\PHPUnit\StaticPHPUnitEnvironment;
 
+/**
+ * @see \Rector\Tests\Skipper\Skipper\SkippedClassResolverTest
+ */
 final class SkippedClassResolver
 {
     /**
-     * @var null|array<string, string[]|null>
+     * @var null|array<class-string, string[]|null>
      */
-    private null|array $skippedClasses = null;
+    private null|array $skippedClassesToFiles = null;
 
     /**
-     * @return array<string, string[]|null>
+     * @return array<class-string<DeprecatedInterface>>
+     */
+    public function resolveDeprecatedSkippedClasses(): array
+    {
+        $skippedClassNames = array_keys($this->resolve());
+
+        return array_filter(
+            $skippedClassNames,
+            fn (string $class): bool => is_a($class, DeprecatedInterface::class, true)
+        );
+    }
+
+    /**
+     * @return array<class-string, string[]|null>
      */
     public function resolve(): array
     {
         // disable cache in tests
         if (StaticPHPUnitEnvironment::isPHPUnitRun()) {
-            $this->skippedClasses = null;
+            $this->skippedClassesToFiles = null;
         }
 
         // already cached, even only empty array
-        if ($this->skippedClasses !== null) {
-            return $this->skippedClasses;
+        if ($this->skippedClassesToFiles !== null) {
+            return $this->skippedClassesToFiles;
         }
 
         $skip = SimpleParameterProvider::provideArrayParameter(Option::SKIP);
-        $this->skippedClasses = [];
+        $this->skippedClassesToFiles = [];
 
         foreach ($skip as $key => $value) {
             // e.g. [SomeClass::class] → shift values to [SomeClass::class => null]
@@ -49,9 +66,9 @@ public function resolve(): array
                 continue;
             }
 
-            $this->skippedClasses[$key] = $value;
+            $this->skippedClassesToFiles[$key] = $value;
         }
 
-        return $this->skippedClasses;
+        return $this->skippedClassesToFiles;
     }
 }

tests/Skipper/Skipper/SkippedClassResolverTest.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Skipper\Skipper;
+
+use Rector\Skipper\SkipCriteriaResolver\SkippedClassResolver;
+use Rector\Testing\PHPUnit\AbstractLazyTestCase;
+
+final class SkippedClassResolverTest extends AbstractLazyTestCase
+{
+    public function test(): void
+    {
+        $skippedClassResolver = $this->make(SkippedClassResolver::class);
+
+        $this->assertSame([], $skippedClassResolver->resolveDeprecatedSkippedClasses());
+    }
+}