fix: convert static::* to self::* for all constant access in final classes

Author: calebdw

rules-tests/CodeQuality/Rector/ClassConstFetch/ConvertStaticPrivateConstantToSelfRector/Fixture/final_class_with_inherited_constant.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\ConvertStaticPrivateConstantToSelfRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\ClassConstFetch\ConvertStaticPrivateConstantToSelfRector\Source\ParentClass;
+
+final class FinalClassWithInheritedConstant extends ParentClass
+{
+    public function run(): void
+    {
+        return static::FAILURE;
+        return static::SUCCESS;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\ConvertStaticPrivateConstantToSelfRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\ClassConstFetch\ConvertStaticPrivateConstantToSelfRector\Source\ParentClass;
+
+final class FinalClassWithInheritedConstant extends ParentClass
+{
+    public function run(): void
+    {
+        return self::FAILURE;
+        return self::SUCCESS;
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/ClassConstFetch/ConvertStaticPrivateConstantToSelfRector/Source/ParentClass.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassConstFetch\ConvertStaticPrivateConstantToSelfRector\Source;
+
+class ParentClass
+{
+    public const FAILURE = 1;
+    protected const SUCCESS = 0;
+}

rules/CodeQuality/Rector/ClassConstFetch/ConvertStaticPrivateConstantToSelfRector.php

@@ -17,24 +17,56 @@
  * @see \Rector\Tests\CodeQuality\Rector\ClassConstFetch\ConvertStaticPrivateConstantToSelfRector\ConvertStaticPrivateConstantToSelfRectorTest
  *
  * @see https://3v4l.org/8Y0ba
+ * @see https://3v4l.org/ZIeA1
  * @see https://phpstan.org/r/11d4c850-1a40-4fae-b665-291f96104d11
  */
 final class ConvertStaticPrivateConstantToSelfRector extends AbstractRector
 {
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
-            'Replaces static::* access to private constants with self::*',
+            'Replaces static::* constant access with self::* for private constants and in final classes.',
             [
                 new CodeSample(
                     <<<'CODE_SAMPLE'
+class Foo
+{
+    private const BAR = 'bar';
+    public const BAZ = 'baz';
+
+    public function run()
+    {
+        $bar = static::BAR;
+        $baz = static::BAZ;
+    }
+}
+CODE_SAMPLE
+                    ,
+                    <<<'CODE_SAMPLE'
+class Foo
+{
+    private const BAR = 'bar';
+    public const BAZ = 'baz';
+
+    public function run()
+    {
+        $bar = self::BAR;
+        $baz = static::BAZ;
+    }
+}
+CODE_SAMPLE
+                ),
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
 final class Foo
 {
     private const BAR = 'bar';
+    public const BAZ = 'baz';
 
     public function run()
     {
         $bar = static::BAR;
+        $baz = static::BAZ;
     }
 }
 CODE_SAMPLE
@@ -43,10 +75,12 @@ public function run()
 final class Foo
 {
     private const BAR = 'bar';
+    public const BAZ = 'baz';
 
     public function run()
     {
         $bar = self::BAR;
+        $baz = self::BAZ;
     }
 }
 CODE_SAMPLE
@@ -68,7 +102,7 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Class_
     {
-        if ($node->getConstants() === []) {
+        if ($node->getConstants() === [] && ! $node->isFinal()) {
             return null;
         }