perf: use hash map for installed packages (#7878)

* perf: use hash map for installed packages

We can turn a package lookup into O(1) by using a hash map instead of an
O(n) with a linear array.

* chore: review updates

Author: calebdw

src/Composer/InstalledPackageResolver.php

@@ -17,7 +17,7 @@
 final class InstalledPackageResolver
 {
     /**
-     * @var null|InstalledPackage[]
+     * @var null|array<string, InstalledPackage>
      */
     private ?array $resolvedInstalledPackages = null;
 
@@ -33,7 +33,7 @@ public function __construct(
     }
 
     /**
-     * @return InstalledPackage[]
+     * @return array<string, InstalledPackage>
      */
     public function resolve(): array
     {
@@ -61,28 +61,26 @@ public function resolve(): array
 
     public function resolvePackageVersion(string $packageName): ?string
     {
-        $installedPackages = $this->resolve();
-        foreach ($installedPackages as $installedPackage) {
-            if ($installedPackage->getName() !== $packageName) {
-                continue;
-            }
+        $package = $this->resolve()[$packageName] ?? null;
 
-            return $installedPackage->getVersion();
+        if (! $package instanceof InstalledPackage) {
+            return null;
         }
 
-        return null;
+        return $package->getVersion();
     }
 
     /**
      * @param mixed[] $packages
-     * @return InstalledPackage[]
+     * @return array<string, InstalledPackage>
      */
     private function createInstalledPackages(array $packages): array
     {
         $installedPackages = [];
 
         foreach ($packages as $package) {
-            $installedPackages[] = new InstalledPackage($package['name'], $package['version_normalized']);
+            $name = $package['name'];
+            $installedPackages[$name] = new InstalledPackage($name, $package['version_normalized']);
         }
 
         return $installedPackages;

src/Composer/ValueObject/InstalledPackage.php

@@ -4,6 +4,9 @@
 
 namespace Rector\Composer\ValueObject;
 
+/**
+ * @api
+ */
 final readonly class InstalledPackage
 {
     public function __construct(

src/Set/ValueObject/ComposerTriggeredSet.php

@@ -40,19 +40,17 @@ public function getSetFilePath(): string
     }
 
     /**
-     * @param InstalledPackage[] $installedPackages
+     * @param array<string, InstalledPackage> $installedPackages
      */
     public function matchInstalledPackages(array $installedPackages): bool
     {
-        foreach ($installedPackages as $installedPackage) {
-            if ($installedPackage->getName() !== $this->packageName) {
-                continue;
-            }
+        $package = $installedPackages[$this->packageName] ?? null;
 
-            return Semver::satisfies($installedPackage->getVersion(), '^' . $this->version);
+        if (! $package instanceof InstalledPackage) {
+            return false;
         }
 
-        return false;
+        return Semver::satisfies($package->getVersion(), '^' . $this->version);
     }
 
     public function getName(): string